Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-1006 Strip extension config #100

Merged
merged 5 commits into from
Sep 21, 2015

Conversation

valotas
Copy link
Contributor

@valotas valotas commented Sep 3, 2015

Made the module name computation configurable.

@maxwellpeterson-wf
Copy link
Contributor

You'll need to pass the config onto the client in init.js similar to here: https://github.com/Workiva/karma-jspm/blob/master/src/init.js#L78

@valotas
Copy link
Contributor Author

valotas commented Sep 6, 2015

Done.

Why don't you just copy the whole object? It is very easy to forget to do that otherwise.

@trentgrover-wf
Copy link
Collaborator

@maxwellpeterson-wf
Copy link
Contributor

@valotas good point, we should do that. Want to submit a patch? :)

+1
@jayudey-wf ready for merge

@valotas
Copy link
Contributor Author

valotas commented Sep 21, 2015

Sure. I'll have a look at it within the week

@jayudey-wf jayudey-wf changed the title Strip extension config CP-1006 Strip extension config Sep 21, 2015
@evanweible-wf
Copy link
Contributor

+1

@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction (gathered from discussion with Max Peterson)
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • installed in another project that consumes karma-jspm, verified that tasks were still working as expected
  • Unit test created/updated
  • All unit tests pass

Merging into mast

jayudey-wf added a commit that referenced this pull request Sep 21, 2015
@jayudey-wf jayudey-wf merged commit f7b480d into computmaxer:master Sep 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants