Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-1340 feat(config): nocache support for jspm.loadFiles Closes #114 (additionally #113) #115

Merged
merged 1 commit into from
Feb 8, 2016

Conversation

comdiv
Copy link
Contributor

@comdiv comdiv commented Dec 1, 2015

Forces file reread in watch cycle
(required for tests in current edit)
Additionally common problem with testing on windows fixed

Closes #114 #113

Forces file reread in watch cycle
(required for tests in current edit)
Additionally common problem with testing on windows fixed

Closes computmaxer#114 computmaxer#113
@RomanHotsiy
Copy link

@comdiv can you add nocache support for jspm_packages dir as well ?
Without that karma crashes on OS X because of too many opened files at the same time.

Adding the following line:
jspmPattern.nocache = jspm.nocache;
after this one and specifying nocache: true in options helps.

Can you please add this feature to your PR? (I can do own PR but just don't want to multiply PRs)

@comdiv
Copy link
Contributor Author

comdiv commented Dec 8, 2015

ok will try

@fabioelia
Copy link

+1 Cause for alot of headaches please get a PR going for this.
"EMFILE: too many open files..."

@NateRedding
Copy link

+1 Please merge!!

@maxwellpeterson-wf
Copy link
Contributor

@evanweible-wf
Copy link
Contributor

+1

@trentgrover-wf
Copy link
Collaborator

+1
@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title feat(config): nocache support for jspm.loadFiles Closes #114 (additionally #113) CP-1340 feat(config): nocache support for jspm.loadFiles Closes #114 (additionally #113) Feb 5, 2016
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction (derived from conversation with Max Peterson)
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI w/ updated tests
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Feb 8, 2016
CP-1340 feat(config): nocache support for jspm.loadFiles Closes #114  (additionally #113)
@jayudey-wf jayudey-wf merged commit 3999ab7 into computmaxer:master Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify 'nocache' in loadFile descriptor
8 participants