Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-2409 Update glob dependency #173

Merged
merged 1 commit into from
Aug 10, 2016
Merged

CP-2409 Update glob dependency #173

merged 1 commit into from
Aug 10, 2016

Conversation

BBosman
Copy link
Contributor

@BBosman BBosman commented Aug 5, 2016

Currently installing karma-jspm gives a warning:

npm WARN deprecated [email protected]: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

This PR updates the glob dependency to the most recent version which uses an updated minimatch version as well.

I ran the tests after the change and they all still pass.

This PR should also fix #166.

@aviary2-wf
Copy link

Raven

Number of Findings: 0

@evanweible-wf
Copy link
Contributor

+1

@maxwellpeterson-wf @trentgrover-wf

@maxwellpeterson-wf
Copy link
Contributor

+1
@jayudey-wf ready for merge.

@jayudey-wf jayudey-wf changed the title Update glob dependency CP-2409 Update glob dependency Aug 10, 2016
@jayudey-wf
Copy link
Contributor

jayudey-wf commented Aug 10, 2016 •
edited
Loading

QA Resource Approval: +10

  • Testing instruction (derived from discussion with Max Peterson)
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI
  • Unit test created/updated
  • All unit tests pass

Merging into master.

@jayudey-wf jayudey-wf merged commit 888064a into computmaxer:master Aug 10, 2016
@charliekump-wf charliekump-wf mentioned this pull request Aug 10, 2016
Closed
@BBosman BBosman deleted the glob branch August 10, 2016 17:24
@rm-astro-wf rm-astro-wf mentioned this pull request Feb 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "glob" dependency to 6 to get rid of negate behavior
5 participants
@BBosman @aviary2-wf @evanweible-wf @maxwellpeterson-wf @jayudey-wf