-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-767 Save CPU cycles by not watching jspm_packages directory for changes. #53
Conversation
Thanks for the contribution! You'll need to fix this line of the unit test: https://github.com/Workiva/karma-jspm/blob/master/test/testInit.spec.js#L58 in order to get a passing build. |
@maxwellpeterson-wf looks like this PR was abandoned, so if it's useful, might as well finish it off yourself |
@maxwellpeterson-wf I'm a bit embarrassed that I didn't run the tests on the unit-testing addon :~) Thanks for pointing out the exact line number. @trentgrover-wf Thanks for comment. Crazy house move pushed this and a dozen other things off the end of the queue. I needed the reminder, sadly. |
+1 |
I was just about to contribute a PR with the exact same purpose as this, glad someone else got there first! 👍 How often do you guys do releases i.e. when is this likely to be out on npm? |
+1 |
QA Resource Approval: +10
Merging into master. |
CP-767 Save CPU cycles by not watching jspm_packages directory for changes.
One could also set usePolling to false and pray.