Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-767 Save CPU cycles by not watching jspm_packages directory for changes. #53

Merged
merged 5 commits into from
Jul 16, 2015

Conversation

ggranum
Copy link
Contributor

@ggranum ggranum commented May 12, 2015

One could also set usePolling to false and pray.

@maxwellpeterson-wf
Copy link
Contributor

Thanks for the contribution! You'll need to fix this line of the unit test: https://github.com/Workiva/karma-jspm/blob/master/test/testInit.spec.js#L58 in order to get a passing build.

@trentgrover-wf
Copy link
Collaborator

@maxwellpeterson-wf looks like this PR was abandoned, so if it's useful, might as well finish it off yourself

@ggranum
Copy link
Contributor Author

ggranum commented Jul 13, 2015

@maxwellpeterson-wf I'm a bit embarrassed that I didn't run the tests on the unit-testing addon :~) Thanks for pointing out the exact line number.

@trentgrover-wf Thanks for comment. Crazy house move pushed this and a dozen other things off the end of the queue. I needed the reminder, sadly.

@trentgrover-wf
Copy link
Collaborator

+1

@gavinaiken
Copy link

I was just about to contribute a PR with the exact same purpose as this, glad someone else got there first! 👍 How often do you guys do releases i.e. when is this likely to be out on npm?

@maxwellpeterson-wf
Copy link
Contributor

+1
@jayudey-wf ready for merge
@gavinaiken I can get this in a patch release once it is merged and goes through our release process. Likely will be on npm tomorrow morning.

@jayudey-wf jayudey-wf changed the title Save CPU cycles by not watching jspm_packages directory for changes. CP-767 Save CPU cycles by not watching jspm_packages directory for changes. Jul 16, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Jul 16, 2015
CP-767 Save CPU cycles by not watching jspm_packages directory for changes.
@jayudey-wf jayudey-wf merged commit 30a09ad into computmaxer:master Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants