Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-899 Move System null-check to a useful location #94

Merged
merged 1 commit into from
Aug 25, 2015
Merged

CP-899 Move System null-check to a useful location #94

merged 1 commit into from
Aug 25, 2015

Conversation

maxwellpeterson-wf
Copy link
Contributor

Issue

Fixes #93

Changes

Source:

  • Move null check of System above first usage
  • minor style fixes

Tests:

  • No change

Areas of Regression

  • None

Testing

  • Ensure karma-jspm still works with another Workiva repository

@trentgrover-wf
@evanweible-wf
@dustinlessard-wf
FYI @jayudey-wf

@maxwellpeterson-wf maxwellpeterson-wf changed the title Move System null-check into useful location Move System null-check to a useful location Aug 25, 2015
@dustinlessard-wf
Copy link
Contributor

+1

1 similar comment
@evanweible-wf
Copy link
Contributor

+1

@maxwellpeterson-wf
Copy link
Contributor Author

@jayudey-wf ready for merge

@jayudey-wf jayudey-wf changed the title Move System null-check to a useful location CP-899 Move System null-check to a useful location Aug 25, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • installed into a project that consumes karma-jspm, ran gulp dist and gulp test and both completed as expected
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Aug 25, 2015
@jayudey-wf
Merge pull request #94 from Workiva/system-check
8d9d7c7 
CP-899 Move System null-check to a useful location
@jayudey-wf jayudey-wf merged commit 8d9d7c7 into master Aug 25, 2015
@trentgrover-wf trentgrover-wf deleted the system-check branch September 21, 2015 05:21
@jayudey-wf
Copy link
Contributor

@Rosie run_merge_script

@jayudey-wf jayudey-wf mentioned this pull request Oct 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid check
5 participants
@maxwellpeterson-wf @dustinlessard-wf @evanweible-wf @jayudey-wf @computmaxer