Fix blank node correlation (closes #795) #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new BlankNodeBindingsScoped class
rubensworks
reviewed
Mar 29, 2021
packages/actor-query-operation-construct/lib/BindingsToQuadsIterator.ts
Outdated
Show resolved
Hide resolved
rubensworks
reviewed
Mar 29, 2021
rubensworks
reviewed
Mar 29, 2021
packages/actor-query-operation-project/lib/ActorQueryOperationProject.ts
Show resolved
Hide resolved
rubensworks
reviewed
Mar 29, 2021
rubensworks
reviewed
Mar 29, 2021
Pull Request Test Coverage Report for Build 697246866
💛 - Coveralls |
…operation-construct
…labels for blank nodes produced by BNODE() expressions
rubensworks
reviewed
Mar 29, 2021
packages/actor-query-operation-construct/lib/BindingsToQuadsIterator.ts
Outdated
Show resolved
Hide resolved
rubensworks
reviewed
Mar 29, 2021
|
Super, thanks for all your work on this! |
|
My pleasure! Do you think it'd be possible to publish a new version of Comunica soon-ish? Even a beta one, doesn't have to be an official release. |
This was referenced Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (
which depends on comunica/sparqlee#81MERGED) fixes the blank node correlation issue raised in issue #795 (and may fix other similar issues).TODO
packages/actor-query-operation-project/lib/ActorQueryOperationProject.tsActorQueryOperationtests to account for thebnodefunctions in expression contextssparqleeonce Preserve original blank nodes when using custom bnode generator functions sparqlee#81 is merged and published to NPM