-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EnrichingProxy to run enrichment during !Lookups #45
base: master
Are you sure you want to change the base?
Conversation
@akx in your opinion, should this work (it doesn't)? Lines 102 to 113 in ba1b01d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless of the new failing test I added, LGTM & make a new issue about recursive data structures.
Also once this is merged, let's release 0.3.0. We've added new tags and this change may introduce subtle changes in the degree of laziness, so incrementing the minor is warranted (would probably be 2.0.0 if we were already 1.x). |
See five:
- - []
two:
- - [] 🤔 |
As far as correctness goes, it should, shouldn't it? |
It seems to work... Got ideas for better test cases?
Fixes #15