Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build and host profiles #250

Merged
merged 2 commits into from
Sep 7, 2020
Merged

Add build and host profiles #250

merged 2 commits into from
Sep 7, 2020

Conversation

cschlosser
Copy link
Contributor

Add option to make conan detection silent since it's triggered
three times otherwise when build and host profiles are specified.

Make conan detection silent since it's triggered
three times otherwise when build and host profiles
are specified.
@CLAassistant
Copy link

CLAassistant commented Jun 16, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cschlosser
❌ Christoph Schlosser


Christoph Schlosser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@czoido czoido closed this Jul 7, 2020
@czoido czoido reopened this Jul 7, 2020
@a4z
Copy link

a4z commented Aug 25, 2020

what is the status of this PR?
nothing happens since more than 1 month. is there an other solution for using the new 2 profiles way, or something missing?

@czoido czoido closed this Aug 28, 2020
@czoido czoido reopened this Aug 28, 2020
@czoido czoido added this to the 0.16 milestone Aug 28, 2020
@czoido
Copy link
Contributor

czoido commented Aug 28, 2020

Hi @cschlosser thanks a lot for the contribution
Adding this to the milestone of the next release

cc @a4z

@czoido czoido requested a review from jgsogo August 31, 2020 16:30
Copy link
Contributor

@jgsogo jgsogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, I would say that the --profile:host (or --profile, it is the same) should take the value from any of the existing profile variables: DEBUG_PROFILE, RELEASE_PROFILE, RELWITHDEBINFO_PROFILE, MINSIZEREL_PROFILE or PROFILE like it is doing right now, and we should add only the new BUILD_PROFILE variable (not sure if PROFILE_BUILD would be a better name).

conan.cmake Outdated Show resolved Hide resolved
conan.cmake Outdated Show resolved Hide resolved
@czoido
Copy link
Contributor

czoido commented Sep 7, 2020

Hi @cschlosser,
I have added some suggestions as I can't push to your branch. Could you please check when possible?

@czoido czoido requested a review from jgsogo September 7, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants