-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build and host profiles #250
Conversation
Make conan detection silent since it's triggered three times otherwise when build and host profiles are specified.
Christoph Schlosser seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
what is the status of this PR? |
Hi @cschlosser thanks a lot for the contribution cc @a4z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO, I would say that the --profile:host
(or --profile
, it is the same) should take the value from any of the existing profile variables: DEBUG_PROFILE
, RELEASE_PROFILE
, RELWITHDEBINFO_PROFILE
, MINSIZEREL_PROFILE
or PROFILE
like it is doing right now, and we should add only the new BUILD_PROFILE
variable (not sure if PROFILE_BUILD
would be a better name).
Hi @cschlosser, |
Co-authored-by: Carlos Zoido <[email protected]>
Add option to make conan detection silent since it's triggered
three times otherwise when build and host profiles are specified.