Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[question] why does the openblas recipe add gfortran to the system_libs? #5338

Open
lexknuther opened this issue Apr 26, 2021 · 1 comment
Open

[question] why does the openblas recipe add gfortran to the system_libs? #5338

lexknuther opened this issue Apr 26, 2021 · 1 comment
Labels
question Further information is requested

Comments

@lexknuther
Copy link

lexknuther commented Apr 26, 2021 •
edited
Loading

Why does the openblas recipe add gfortran to it's system libs? Removing this seems to have no impact on a variety of Linux OSes (Ubuntu 20.04, CentOS 7, RHEL 8, etc.). I thought that libgfortran was the libc equivalent for fortran and was automatically linked to all fortran executables. The commit messages surrounding this change are generic "updated the recipe" ones.
@lexknuther lexknuther added the question Further information is requested label Apr 26, 2021
@samuel-emrys
Copy link
Contributor

I'm pretty sure because to build openblas with lapack support you need to use a fortran compiler. Adding this as a system lib I assume makes the compiler discoverable by openblas, and so when it goes to build it can build with lapack support. Removing it appears to have no impact because:
(a) you haven't enabled a lapack build
(b) you don't have gfortran installed
(c) it does have an impact because you're no longer able to build it with lapack support

Note that openblas will fallback to compiling without lapack support if it can't find a fortran compiler - this doesn't trigger a build fail.

joakimono added a commit to joakimono/conan-center-index that referenced this issue Apr 23, 2023
@joakimono
openblas: Improve recipe plus conan v2
e35f3b7 
    - Allow disabling AVX512 via env variable, workaround for conan-io#12705
    - Only make gfortran a dependency if actually used, related to conan-io#5910, conan-io#1867, conan-io#5338
    - Add latest OpenBLAS release version 0.3.23
    - Move replace_in_file to patches instead
    - Fix intel fortran compiler identification in OpenBLAS cmake
    - Allow build_lapack without fortran using C_LAPACK since 0.3.23
joakimono added a commit to joakimono/conan-center-index that referenced this issue Apr 23, 2023
@joakimono
openblas: Improve recipe plus conan v2
7061848 
    - Allow disabling AVX512 via env variable, workaround for conan-io#12705
    - Only make gfortran a dependency if actually used, related to conan-io#5910, conan-io#1867, conan-io#5338
    - Add latest OpenBLAS release version 0.3.23
    - Move replace_in_file to patches instead
    - Fix intel fortran compiler identification in OpenBLAS cmake
    - Allow build_lapack without fortran using C_LAPACK since 0.3.23
@joakimono joakimono mentioned this issue Apr 23, 2023
Closed
3 tasks
joakimono added a commit to joakimono/conan-center-index that referenced this issue Apr 23, 2023
@joakimono
openblas: Improve recipe plus conan v2
fc62160 
    - Allow disabling AVX512 via env variable, workaround for conan-io#12705
    - Only make gfortran a dependency if actually used, related to conan-io#5910, conan-io#1867, conan-io#5338
    - Add latest OpenBLAS release version 0.3.23
    - Move replace_in_file to patches instead
    - Fix intel fortran compiler identification in OpenBLAS cmake
    - Allow build_lapack without fortran using C_LAPACK since 0.3.23
joakimono added a commit to joakimono/conan-center-index that referenced this issue May 3, 2023
@joakimono
openblas: Improve recipe plus conan v2
b58023d 
    - Allow disabling AVX512 via env variable, workaround for conan-io#12705
    - Only make gfortran a dependency if actually used, related to conan-io#5910, conan-io#1867, conan-io#5338
    - Add latest OpenBLAS release version 0.3.23
    - Move replace_in_file to patches instead
    - Fix intel fortran compiler identification in OpenBLAS cmake
    - Allow build_lapack without fortran using C_LAPACK since 0.3.23
joakimono added a commit to joakimono/conan-center-index that referenced this issue May 8, 2023
@joakimono
openblas: Improve recipe plus conan v2
4fa9687 
    - Allow disabling AVX512 via env variable, workaround for conan-io#12705
    - Only make gfortran a dependency if actually used, related to conan-io#5910, conan-io#1867, conan-io#5338
    - Add latest OpenBLAS release version 0.3.23
    - Move replace_in_file to patches instead
    - Fix intel fortran compiler identification in OpenBLAS cmake
    - Allow build_lapack without fortran using C_LAPACK since 0.3.23
joakimono added a commit to joakimono/conan-center-index that referenced this issue May 10, 2023
@joakimono
openblas: Improve recipe plus conan v2
67e0d27 
    - Allow disabling AVX512 via env variable, workaround for conan-io#12705
    - Only make gfortran a dependency if actually used, related to conan-io#5910, conan-io#1867, conan-io#5338
    - Add latest OpenBLAS release version 0.3.23
    - Move replace_in_file to patches instead
    - Fix intel fortran compiler identification in OpenBLAS cmake
    - Allow build_lapack without fortran using C_LAPACK since 0.3.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexknuther @samuel-emrys