[cairo] v2 support #12240

planetmarshall · 2022-08-15T18:48:13Z

Specify library name and version: cairo/

The cairo package sets the name of the base pkg-config component file to "cairo" which renames the default parent component (the one containing all the sub-components).

The result is that dependent packages using the pkg-config generator and linking to "cairo" only get the base cairo component and not additional components such as cairo-gobject. This can result linking errors in dependent packages (specifically in the MSVC build of gtkmm which expects cairo to also include cairo-gobject)

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the conan-center hook activated.

github-actions · 2022-08-15T21:26:03Z

Hooks produced the following warnings for commit 499575d

cairo/1.17.2

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-gobject.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-script-interpreter.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/cairo/libcairo-trace.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.2.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-gobject.2.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-script-interpreter.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-script-interpreter.2.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-gobject.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.

cairo/1.16.0

post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-gobject.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-script-interpreter.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/cairo/libcairo-trace.so' links to system library 'rt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.2.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-gobject.2.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-script-interpreter.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-script-interpreter.2.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/libcairo-gobject.dylib' links to system library 'ApplicationServices' but it is not in cpp_info.frameworks.

recipes/cairo/all/conanfile.py

theartful · 2022-08-25T17:22:47Z

@planetmarshall There has to be a component that just has the pkg-config name "cairo" since many libraries expect it to exist. These changes make it that no pkg-config file is named "cairo.pc".

SpaceIm · 2022-08-25T23:38:35Z

recipes/cairo/all/conanfile.py

+        def boolean(value):
+            return "yes" if value else "no"


yes_no lambda was more elegant I believe, why this change?

Rejected by the linter ( PEP-8 - E731 in Flake8 ).

As for the naming, I think boolean is a better name for a function than yes_no.

SpaceIm · 2022-08-25T23:42:32Z

recipes/cairo/meson/conanfile.py

+
+        def add_component_and_base_requirements(component, requirements, system_libs=None):
+            self.cpp_info.components[component].set_property("pkg_config_name", component)
+            self.cpp_info.components[component].names["pkg_config"] = component


Can be removed, pkg_config generator inherits frompkg_config_name property in components as well (also in global scope but only since a version I don't remember where it was fixed, but far before conan 1.50.0 which is the minimum in this PR).

I thought we broke the connection between v1 and v2 generators 🤔 was that only for CMake?

Since we have not removed it in other recipes, I dont see the harm in leaving it here as well

SpaceIm · 2022-08-25T23:43:38Z

recipes/cairo/meson/conanfile.py

+        self.cpp_info.names["pkg_config"] = "cairo-all-do-no-use"
+
+        self.cpp_info.components["cairo_"].set_property("pkg_config_name", "cairo")
+        self.cpp_info.components["cairo_"].names["pkg_config_name"] = "cairo"


Suggested change

self.cpp_info.components["cairo_"].names["pkg_config_name"] = "cairo"

useless if pkg_config_name is there

Awaiting consensus from reviewers.

... although this should be ["pkg_config"].name anyway. (typo)

SpaceIm · 2022-08-25T23:44:01Z

recipes/cairo/meson/conanfile.py

+
+        def add_component_and_base_requirements(component, requirements, system_libs=None):
+            self.cpp_info.components[component].set_property("pkg_config_name", component)
+            self.cpp_info.components[component].names["pkg_config"] = component


Suggested change

self.cpp_info.components[component].names["pkg_config"] = component

Awaiting consensus from reviewers.

@planetmarshall you can remove

uilianries · 2022-08-31T13:32:23Z

recipes/cairo/all/conanfile.py

            self.build_requires("libtool/2.4.6")
            self.build_requires("pkgconf/1.7.4")
            self.build_requires("gtk-doc-stub/cci.20181216")


Suggested change

self.build_requires("libtool/2.4.6")

self.build_requires("pkgconf/1.7.4")

self.build_requires("gtk-doc-stub/cci.20181216")

self.tool_requires("libtool/2.4.6")

self.tool_requires("pkgconf/1.7.4")

self.tool_requires("gtk-doc-stub/cci.20181216")

https://docs.conan.io/en/latest/migrating_to_2.0/recipes.html#requirements

conan-center-bot · 2022-08-31T20:07:56Z

All green in build 22 (49787f55d6fabeb07d6e4a1f4519e759d9ff94c3):

cairo/1.17.4@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12240/recipes/cairo/meson/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12240/recipes/cairo/meson/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12240/recipes/cairo/meson/conanfile.py", line 8, in <module>
    from conans import tools, Meson, VisualStudioBuildEnvironment
ImportError: cannot import name 'tools' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cairo/1.16.0@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12240/recipes/cairo/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12240/recipes/cairo/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12240/recipes/cairo/all/conanfile.py", line 7, in <module>
    from conans import AutoToolsBuildEnvironment, VisualStudioBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

cairo/1.17.2@:
All packages built successfully! (All logs)

🔸 Informative: This recipe is not ready for Conan v2

_{We have started the migration process to Conan v2 and exporting recipes successfully will be required in the future.

This is just an informative note to gain awareness about the process, no need to take any action. The plan is to enforce smaller steps that are easier to fix and, eventually, this conan export step will work.

See the recipe migration guide to know more about the changes required.}

ERROR: Error loading conanfile at '/home/conan/w/prod_cci_PR-12240/recipes/cairo/all/conanfile.py': Unable to load conanfile in /home/conan/w/prod_cci_PR-12240/recipes/cairo/all/conanfile.py
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/home/conan/w/prod_cci_PR-12240/recipes/cairo/all/conanfile.py", line 7, in <module>
    from conans import AutoToolsBuildEnvironment, VisualStudioBuildEnvironment
ImportError: cannot import name 'AutoToolsBuildEnvironment' from 'conans' (/opt/pyenv/versions/3.7.13/lib/python3.7/site-packages/conans/__init__.py)

* [cairo] do not rename the parent pkg-config package * [cairo] refactor and simplify package_info method * [cairo] fix v2 linting * [cairo] provide parent pkgconfig and use set_property_name * [cairo] resolve system lib warnings * [cairo] v2 linting * Apply review suggestion Co-authored-by: Uilian Ries <[email protected]> * Apply review suggestion Co-authored-by: Uilian Ries <[email protected]> * [cairo] bump requirements versions * [cairo] full package mode only for static glib * [cairo] shared glib with static msvcrt is not supported * [cairo] restore old pkg-config file names * [cairo] update source method * [cairo] restore main pkg-config name * [cairo] fix property name typo * [cairo] use tool_requires Co-authored-by: Uilian Ries <[email protected]>

[cairo] do not rename the parent pkg-config package

5b0d226

github-actions bot mentioned this pull request Aug 15, 2022

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Aug 15, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 15, 2022

planetmarshall added 2 commits August 15, 2022 20:44

[cairo] refactor and simplify package_info method

85e8ff5

[cairo] fix v2 linting

499575d

planetmarshall force-pushed the cairo-parent-component branch from a4eb122 to 499575d Compare August 15, 2022 19:44

conan-center-bot removed the Failed label Aug 15, 2022

This comment has been minimized.

Sign in to view

SpaceIm reviewed Aug 15, 2022

View reviewed changes

recipes/cairo/all/conanfile.py Show resolved Hide resolved

planetmarshall added 2 commits August 16, 2022 09:29

[cairo] provide parent pkgconfig and use set_property_name

649296e

[cairo] resolve system lib warnings

d865d22

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 16, 2022

planetmarshall closed this Aug 16, 2022

planetmarshall reopened this Aug 16, 2022

conan-center-bot removed the Failed label Aug 16, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Aug 16, 2022

planetmarshall closed this Aug 16, 2022

planetmarshall reopened this Aug 16, 2022

conan-center-bot removed the Failed label Aug 16, 2022

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Aug 16, 2022

[cairo] v2 linting

6faf10e

[cairo] restore old pkg-config file names

970914b

planetmarshall dismissed uilianries’s stale review via 970914b August 24, 2022 17:33

planetmarshall changed the title ~~[cairo] rename parent component~~ [cairo] v2 support Aug 24, 2022

[cairo] update source method

8d6d988

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Aug 24, 2022

This comment has been minimized.

Sign in to view

prince-chrismc previously approved these changes Aug 25, 2022

View reviewed changes

[cairo] restore main pkg-config name

adf4fb7

planetmarshall dismissed prince-chrismc’s stale review via adf4fb7 August 25, 2022 19:59

This comment has been minimized.

Sign in to view

SpaceIm reviewed Aug 25, 2022

View reviewed changes

conan-center-bot requested a review from uilianries August 29, 2022 12:04

[cairo] fix property name typo

9d6fb61

This comment has been minimized.

Sign in to view

conan-center-bot added Failed and removed Failed labels Aug 31, 2022

uilianries reviewed Aug 31, 2022

View reviewed changes

[cairo] use tool_requires

49787f5

prince-chrismc approved these changes Sep 1, 2022

View reviewed changes

uilianries approved these changes Sep 1, 2022

View reviewed changes

conan-center-bot merged commit 41c4c73 into conan-io:master Sep 1, 2022

ericLemanissier mentioned this pull request Sep 19, 2022

pango 1.50.10 #13011

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[cairo] v2 support #12240

[cairo] v2 support #12240

planetmarshall commented Aug 15, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 15, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

theartful commented Aug 25, 2022

This comment has been minimized.

SpaceIm Aug 25, 2022

planetmarshall Aug 30, 2022

SpaceIm Aug 25, 2022 •

edited

Loading

prince-chrismc Aug 26, 2022

SpaceIm Aug 25, 2022

planetmarshall Aug 30, 2022

planetmarshall Aug 30, 2022

SpaceIm Aug 25, 2022

planetmarshall Aug 30, 2022

uilianries Aug 31, 2022

This comment has been minimized.

uilianries Aug 31, 2022

conan-center-bot commented Aug 31, 2022

[cairo] v2 support #12240

[cairo] v2 support #12240

Conversation

planetmarshall commented Aug 15, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Aug 15, 2022

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

theartful commented Aug 25, 2022

This comment has been minimized.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Aug 25, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment has been minimized.

Choose a reason for hiding this comment

conan-center-bot commented Aug 31, 2022

SpaceIm Aug 25, 2022 •

edited

Loading