-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
krb5: add library version 1.18.2 #14226
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@madebr I try to port your recipe to conan v2. Looks like everything is ok, but I don't understand what's wrong with ksu install. I reproduced problem locally but it didn't help. I can change ownership with chmod but not with install. Do you have any ideas how to fix it? |
I can't reproduce the error on CI. It looks like a rights issue. But the static library has issues:
Building the recipe, I noticed a few outdated packages, so I applied the patch below. diff --git a/recipes/krb5/all/conanfile.py b/recipes/krb5/all/conanfile.py
index 50e4b1be4..239d872af 100644
--- a/recipes/krb5/all/conanfile.py
+++ b/recipes/krb5/all/conanfile.py
@@ -113,7 +113,7 @@ class Krb5Conan(ConanFile):
if not is_msvc(self):
self.requires("libverto/0.3.2")
if self.options.get_safe("with_tls") == "openssl":
- self.requires("openssl/1.1.1q")
+ self.requires("openssl/1.1.1s")
if self.options.get_safe("with_tcl"):
self.requires("tcl/8.6.10")
@@ -169,7 +169,7 @@ class Krb5Conan(ConanFile):
replace_in_file(self, "kdb5_util.c",
"krb5_keyblock master_keyblock;",
"extern krb5_keyblock master_keyblock;")
- with chdir(self, os.path.join(self.source_folder,"src", "tests", "create")):
+ with chdir(self, os.path.join(self.source_folder,"src", "tests", "create")):
replace_in_file(self, "kdb5_mkdums.c",
"krb5_keyblock master_keyblock;",
"extern krb5_keyblock master_keyblock;")
@@ -178,14 +178,14 @@ class Krb5Conan(ConanFile):
"static krb5_principal master_princ;")
replace_in_file(self, "kdb5_mkdums.c",
"krb5_pointer master_random;",
- "static krb5_pointer master_random;")
+ "static krb5_pointer master_random;")
with chdir(self, os.path.join(self.source_folder,"src", "tests", "verify")):
replace_in_file(self, "kdb5_verify.c",
"krb5_keyblock master_keyblock;",
"extern krb5_keyblock master_keyblock;")
replace_in_file(self, "kdb5_verify.c",
"krb5_principal master_princ;",
- "static krb5_principal master_princ;")
+ "static krb5_principal master_princ;")
apply_conandata_patches(self)
if is_msvc(self):
self._build_msvc()
@@ -229,7 +229,7 @@ class Krb5Conan(ConanFile):
self.cpp_info.components["mit-krb5"].libs = [krb5_lib] + crypto_libs + [krb5support]
if not is_msvc(self):
self.cpp_info.components["mit-krb5"].libs.append("com_err") # is a common library, that can potentially be packaged (but I don't know who "owns" it)
-
+
if self.options.get_safe('with_tls') == "openssl":
self.cpp_info.components["mit-krb5"].requires.append("openssl::ssl")
self.cpp_info.components["mit-krb5"].names["pkg_config"] = "mit-krb5"
diff --git a/recipes/krb5/all/test_package/conanfile.py b/recipes/krb5/all/test_package/conanfile.py
index a6564ead1..261d65b1a 100644
--- a/recipes/krb5/all/test_package/conanfile.py
+++ b/recipes/krb5/all/test_package/conanfile.py
@@ -7,7 +7,7 @@ class TestPackageConan(ConanFile):
generators = "cmake", "pkg_config"
def build_requirements(self):
- self.build_requires("pkgconf/1.7.3")
+ self.build_requires("pkgconf/1.9.3")
def build(self):
cmake = CMake(self)
diff --git a/recipes/libevent/all/conanfile.py b/recipes/libevent/all/conanfile.py
index 0a8f1ba78..8ae1637de 100644
--- a/recipes/libevent/all/conanfile.py
+++ b/recipes/libevent/all/conanfile.py
@@ -56,7 +56,7 @@ class LibeventConan(ConanFile):
def requirements(self):
if self.options.with_openssl:
- self.requires("openssl/1.1.1q")
+ self.requires("openssl/1.1.1s")
def source(self):
get(self, **self.conan_data["sources"][self.version],
diff --git a/recipes/libverto/all/conanfile.py b/recipes/libverto/all/conanfile.py
index 8e6ade5b4..30c814e06 100644
--- a/recipes/libverto/all/conanfile.py
+++ b/recipes/libverto/all/conanfile.py
@@ -96,7 +96,7 @@ class LibVertoConan(ConanFile):
def requirements(self):
if self.options.with_glib:
- self.requires("glib/2.69.2")
+ self.requires("glib/2.74.21")
if self.options.with_libevent:
self.requires("libevent/2.1.12")
if self.options.with_libev:
@@ -106,8 +106,8 @@ class LibVertoConan(ConanFile):
raise ConanInvalidConfiguration("tevent is not (yet) available on conan-center")
def build_requirements(self):
- self.build_requires("pkgconf/1.7.4")
- self.build_requires("libtool/2.4.6")
+ self.build_requires("pkgconf/1.9.3")
+ self.build_requires("libtool/2.4.7")
if self._settings_build.os == "Windows" and not tools.get_env("CONAN_BASH_PATH"):
self.build_requires("msys2/cci.latest")
|
I understand but I want to create fully working recipe for old version and then port to current newest. I think it can be easier than drop your patches and create my own |
Conan v1 pipelineFailure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
Specify library name and version: krb5/1.18.2
This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!
Closes #4102