Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debug_assert/1.3.3 #1467

Merged
merged 5 commits into from
May 6, 2020
Merged

Add debug_assert/1.3.3 #1467

merged 5 commits into from
May 6, 2020

Conversation

Manu343726
Copy link
Contributor

@Manu343726 Manu343726 commented Apr 26, 2020

Specify library name and version: debug_assert/1.3.3

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 1:

Only one library can be changed in the same PR: [debug_assert/all, stlab/all]|

@conan-center-bot
Copy link
Collaborator

All green in build 2 (08947015076ce6ede1126e77994cca058033b50c)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 3 (115addcb0752c72ad3439a2fe2824566e74ae6ea)! 😊

@Manu343726 Manu343726 mentioned this pull request Apr 26, 2020
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 5 (aa7caafc5adf7ca797c3766305e7c2588da6a4c2)! 😊

Manu343726 and others added 2 commits April 29, 2020 15:27
To follow existing package conventions (As noted by @madebr).

Co-Authored-By: Anonymous Maarten <[email protected]>
description = 'Simple, flexible and modular assertion macro'
url = 'https://github.com/conan-io/conan-center-index'
homepage = 'http://foonathan.net/blog/2016/09/16/assertions.html'
license = 'zlib'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
license = 'zlib'
license = 'Zlib'

https://spdx.org/licenses/Zlib.html

SSE4
SSE4 previously approved these changes May 4, 2020
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the zlib license as @uilianries pointed, and we're good

@conan-center-bot
Copy link
Collaborator

All green in build 6 (b6d69be21f9d0d3fdb60e81daec2f0c1f38d6d5f)! 😊

@uilianries uilianries requested a review from SSE4 May 5, 2020 19:59
@uilianries uilianries requested a review from jgsogo May 5, 2020 19:59
@jgsogo jgsogo merged commit 37dda87 into conan-io:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants