-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
googleapis: use modern CMake integrations #15450
googleapis: use modern CMake integrations #15450
Conversation
I detected other pull requests that are modifying googleapis/all recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
b1ea37d
to
f900ac0
Compare
from conan.errors import ConanInvalidConfiguration | ||
from conan.tools.build import check_min_cppstd | ||
from conan.tools.cmake import cmake_layout, CMake | ||
from conan.tools.files import apply_conandata_patches, copy, get, export_conandata_patches, copy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from conan.tools.files import apply_conandata_patches, copy, get, export_conandata_patches, copy | |
from conan.tools.files import apply_conandata_patches, copy, get, export_conandata_patches |
This comment has been minimized.
This comment has been minimized.
|
…mes when building
Conan v1 pipeline ✔️All green in build 9 ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Is it possible that this broke
|
|
* googleapis: use modern CMake integrations * Add package_type attribute * Fix applying patches * google-apis: modernise test package * googleapis: use resdirs in components and use shorten cmake target names when building * Apply conandata patches
Specify library name and version: googleapis/all
Summary of changes
This PR updates the
googleapis
recipe to use functionality that is compatible with both Conan 1.x and Conan 2.0CMakeDeps
andCMakeToolchain
instead of legacy integrations.pb.h
headers inside this package have transitive public header dependencies on Protobufconan.tools
resdirs
cpp_info attribute - it needs to be explicitly set in Conan 2.0 as there is no default.package_type
attributeShorten build paths in CMake-generated files:
google_
or end with_proto
- this is in an attempt to get cmake to generate shorter vcxproj files, such that the path to the build-time-only.dir
directory and all temporary files generated by MSBuild have shorter names, to work around the following error:The file names of the built libraries are preserved, as well as the target names that we are parsing in
package_info
.