Z3: Revise the recipe to support Conan v2 and add the latest four minor releases. #17244

0xFireWolf · 2023-04-26T07:52:46Z

Specify library name and version: z3/4.9.1, 4.10.2, 4.11.2, 4.12.1

This PR contains the following changes:

Revise the recipe to make it compatible with both Conan v1 and v2.
Fix an issue that the option multithreaded is passed to Z3's build system improperly.
- The correct CMake variable is Z3_SINGLE_THREADED instead of SINGLE_THREADED.
Remove deprecated old versions, 4.8.x and earlier.
Remove the option multiprecision.
Remove the support for MPIR and its related patches that modify the original CMakeLists.txt for each release.
- Note that Z3 officially supports GMP only. Hacking the build system for each Z3 release to use MPIR instead of GMP makes it hard to maintain the recipe. Users who strongly prefer MPIR to GMP may consider to submit a proposal to Z3's development team.
Add a new boolean option use_gmp whose default value, False, is consistent with the default value of Z3's CMake option Z3_USE_LIB_GMP.
Patch CMakeLists.txt for each supported version to use the GMP library provided by Conan Center.
- Note that this patch is implemented in Python and will be applied if and only if users have specified to use the GMP library (i.e., by setting the option use_gmp=True)
Raise the minimum GCC version to 8.
- Compiling Z3 using GCC 7 leads to an internal compiler error.
Set the flag -stdlib explicitly when compiling Z3 using Clang on Linux to fix the linker errors related to the standard library.
Disable the test suite "DeMorgan" because it triggers a page fault if Z3 v4.11.2 is compiled by Clang in release mode.

Known Issues:
When testing the recipe with the option use_gmp=True, Z3 cannot find the header gmp.h even though Conan has generated the target gmp::gmp successfully. A little help here would be much appreciated. For your convenience, you can test the recipe using the following commands. Note that the CI pipeline won't be able to capture this issue, because by default use_gmp is false.

# Use Z3's internal implementation
conan create all/conanfile.py --version 4.12.1 --build missing -o "z3*:use_gmp=False"
conan create all/conanfile.py --version 4.11.2 --build missing -o "z3*:use_gmp=False"
conan create all/conanfile.py --version 4.10.2 --build missing -o "z3*:use_gmp=False"
conan create all/conanfile.py --version 4.9.1 --build missing -o "z3*:use_gmp=False"

# Use GMP's implementation: gmp.h header not found error
conan create all/conanfile.py --version 4.12.1 --build missing -o "z3*:use_gmp=True"
conan create all/conanfile.py --version 4.11.2 --build missing -o "z3*:use_gmp=True"
conan create all/conanfile.py --version 4.10.2 --build missing -o "z3*:use_gmp=True"
conan create all/conanfile.py --version 4.9.1 --build missing -o "z3*:use_gmp=True"

Please let me know if we can improve this recipe further. Thanks for your time.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

…rary should be used and its default value is consistent with the default value of Z3's CMake option `Z3_USE_LIB_GMP`.

…library provided by Conan Center if and only if users have specified to use GMP.

…fied to use GMP.

…eads to a segfault.

…t when compiled with Z3 v4.11.2 and Clang in release mode.

SpaceIm · 2023-05-07T21:05:41Z

recipes/z3/all/conanfile.py

@@ -21,109 +23,104 @@ class Z3Conan(ConanFile):
        "shared": [True, False],
        "fPIC": [True, False],
        "multithreaded": [True, False],
-        "multiprecision": ["internal", "gmp", "mpir"]
+        "use_gmp": [True, False]


I've read your rational about this change, but do you know that there is set_property in CMakeDeps to avoid patching upstream CMakeLists? I think we can keep this option without any maintenance burden with some smart set_property.

I see what you means. We can pretend that the target name of the MPIR library is GMP::GMP. I will give a try. Thanks for the suggestions.

…brary provided by Conan Center instead of patching `CMakeLists.txt` manually.

CLAassistant · 2023-05-18T13:38:08Z

All committers have signed the CLA.

recipes/z3/all/conandata.yml

conan-center-bot · 2023-05-29T23:41:08Z

Conan v1 pipeline ✔️

All green in build 11 (df863666458ebdd3c0d075afb25c5a86308c427e):

z3/4.12.1@:
All packages built successfully! (All logs)
z3/4.9.1@:
All packages built successfully! (All logs)
z3/4.11.2@:
All packages built successfully! (All logs)
z3/4.10.2@:
All packages built successfully! (All logs)
z3/4.12.2@:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds may be required once they are on the v2 ready list

All green in build 10 (df863666458ebdd3c0d075afb25c5a86308c427e):

z3/4.9.1@:
All packages built successfully! (All logs)
z3/4.10.2@:
All packages built successfully! (All logs)
z3/4.11.2@:
All packages built successfully! (All logs)
z3/4.12.1@:
All packages built successfully! (All logs)
z3/4.12.2@:
All packages built successfully! (All logs)

…cmake-combined-recipe - Resolved conflicts. - Updated recipes/cmake/combined/conandata.yml to use CMake 3.26.4 instead of 3.26.3 * 'master' of github.com:conan-io/conan-center-index: (219 commits) (conan-io#17379) zpp_bits: add version 4.4.17, add package_type (conan-io#17811) mongo-c-driver: add version 1.23.4 (conan-io#17824) [bot] Update list of references (prod-v2/ListPackages) (conan-io#17827) [bot] Update authorized users list (2023-06-05) (conan-io#17791) c4core: update fast_float (conan-io#17447) llhttp: conan v2 support (conan-io#17821) daw_utf_range: update daw_header_libraries (conan-io#17819) add mbits-diags/0.9.5 (conan-io#17471) Add Boost 1.82.0 (conan-io#17816) uni-algo: add version 0.8.1 (conan-io#17815) flatbuffers: add version 23.5.26 (conan-io#17801) Bring tl-function to conan2 (conan-io#17802) Bring ring-span-lite to conan2 (conan-io#16572) ragel: support conan v2 (conan-io#17244) Z3: Revise the recipe to support Conan v2 and add the latest four minor releases. (conan-io#17355) avahi/0.8: Disable the use of the setproctitle function on Linux (conan-io#17744) Bumped CMake to 3.26.4 (conan-io#17763) Libwebsockets support for conan2 (conan-io#17808) octo-logger-cpp: add version 1.4.0 (conan-io#17428) Add libmemcached library ...

…e latest four minor releases. * z3: Remove the entry `base_path` from each patch descriptor. * z3: Create the test package for Conan 1.x. * z3: Make the test package compatible with Conan 2.x. * z3: Make the recipe compatible with Conan 2.x. * z3: Add the latest three stable releases, 4.12.1, 4.11.2, 4.10.2. * z3: Add a new boolean option `use_gmp` to specify whether the GMP library should be used and its default value is consistent with the default value of Z3's CMake option `Z3_USE_LIB_GMP`. * z3: Patch `CMakeLists.txt` for all supported versions to use the GMP library provided by Conan Center if and only if users have specified to use GMP. * z3: Add `gmp/6.2.1` as its dependency if and only if users have specified to use GMP. * z3: Remove the deprecated option `multiprecision`. * z3: Remove unneeded import statements from the recipe. * z3: Remove deprecated patches. * z3: Remove deprecated old versions. * z3: Fix an issue that `CMakeLists.txt` is not patched. * z3: Add version 4.9.1. * z3: Specify the encoding when accessing `CMakeLists.txt`. * z3: Raise the minimum GCC version to 8 because compiling with GCC 7 leads to a segfault. * z3: Set the flag `stdlib` for Clang on Linux to fix the linker errors. * z3: Disable the `DeMorgan` test suite because it triggers a page fault when compiled with Z3 v4.11.2 and Clang in release mode. * z3: Use `replace_in_file` to patch `CMakeLists.txt`. * z3: Use `CMakeDeps.set_property()` to override the name of the GMP library provided by Conan Center instead of patching `CMakeLists.txt` manually. * z3: Add v4.12.2.

prince-chrismc mentioned this pull request Apr 26, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Apr 26, 2023

This comment has been minimized.

Sign in to view

0xFireWolf force-pushed the z3-v2 branch from 6e83cc9 to 1ce083f Compare April 27, 2023 19:34

conan-center-bot removed the Failed label Apr 28, 2023

This comment has been minimized.

Sign in to view

0xFireWolf added 19 commits April 28, 2023 12:57

z3: Remove the entry base_path from each patch descriptor.

15d9d39

z3: Create the test package for Conan 1.x.

65ada13

z3: Make the test package compatible with Conan 2.x.

d610395

z3: Make the recipe compatible with Conan 2.x.

94041c5

z3: Add the latest three stable releases, 4.12.1, 4.11.2, 4.10.2.

64aa0b9

z3: Add a new boolean option use_gmp to specify whether the GMP lib…

c80efa4

…rary should be used and its default value is consistent with the default value of Z3's CMake option `Z3_USE_LIB_GMP`.

z3: Patch CMakeLists.txt for all supported versions to use the GMP …

c8fad7b

…library provided by Conan Center if and only if users have specified to use GMP.

z3: Add gmp/6.2.1 as its dependency if and only if users have speci…

8e98135

…fied to use GMP.

z3: Remove the deprecated option multiprecision.

f2329a1

z3: Remove unneeded import statements from the recipe.

68ec002

z3: Remove deprecated patches.

2c9283e

z3: Remove deprecated old versions.

fbc6f82

z3: Fix an issue that CMakeLists.txt is not patched.

375635e

z3: Add version 4.9.1.

5c4a696

z3: Specify the encoding when accessing CMakeLists.txt.

d43c6a4

z3: Raise the minimum GCC version to 8 because compiling with GCC 7 l…

4a058b8

…eads to a segfault.

z3: Set the flag stdlib for Clang on Linux to fix the linker errors.

f58e51b

z3: Disable the DeMorgan test suite because it triggers a page faul…

f437b13

…t when compiled with Z3 v4.11.2 and Clang in release mode.

z3: Use replace_in_file to patch CMakeLists.txt.

744c79b

0xFireWolf force-pushed the z3-v2 branch from 1ce083f to 744c79b Compare April 28, 2023 19:57

This comment has been minimized.

Sign in to view

SpaceIm reviewed May 7, 2023

View reviewed changes

z3: Use CMakeDeps.set_property() to override the name of the GMP li…

8690259

…brary provided by Conan Center instead of patching `CMakeLists.txt` manually.

0xFireWolf closed this May 11, 2023

0xFireWolf reopened this May 11, 2023

This comment has been minimized.

Sign in to view

conan-center-bot requested review from danimtb and uilianries May 19, 2023 12:00

uilianries reviewed May 23, 2023

View reviewed changes

recipes/z3/all/conandata.yml Show resolved Hide resolved

z3: Add v4.12.2.

df86366

danimtb approved these changes May 30, 2023

View reviewed changes

conan-center-bot requested a review from AbrilRBS June 1, 2023 12:01

SSE4 approved these changes Jun 3, 2023

View reviewed changes

conan-center-bot merged commit 374db56 into conan-io:master Jun 3, 2023

0xFireWolf deleted the z3-v2 branch June 4, 2023 01:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Z3: Revise the recipe to support Conan v2 and add the latest four minor releases. #17244

Z3: Revise the recipe to support Conan v2 and add the latest four minor releases. #17244

0xFireWolf commented Apr 26, 2023 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm May 7, 2023

0xFireWolf May 9, 2023

This comment has been minimized.

CLAassistant commented May 18, 2023 •

edited

Loading

conan-center-bot commented May 29, 2023

Z3: Revise the recipe to support Conan v2 and add the latest four minor releases. #17244

Z3: Revise the recipe to support Conan v2 and add the latest four minor releases. #17244

Conversation

0xFireWolf commented Apr 26, 2023 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm May 7, 2023

Choose a reason for hiding this comment

0xFireWolf May 9, 2023

Choose a reason for hiding this comment

This comment has been minimized.

CLAassistant commented May 18, 2023 • edited Loading

conan-center-bot commented May 29, 2023

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

0xFireWolf commented Apr 26, 2023 •

edited

Loading

CLAassistant commented May 18, 2023 •

edited

Loading