-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onetbb: fixed hwloc setting on Windows #19174
onetbb: fixed hwloc setting on Windows #19174
Conversation
I detected other pull requests that are modifying onetbb/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
For readability could you move generation of pkgconfigdeps after cmaketoolchain logic please. It's confusing with this unecessary interleaved logic. |
cb236df
to
51df797
Compare
This comment has been minimized.
This comment has been minimized.
51df797
to
95a23d1
Compare
This comment has been minimized.
This comment has been minimized.
@RubenRBS could you please review? |
@RubenRBS please, have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see where the error comes from, nice catch!
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 3 (
|
Specify library name and version: onetbb/2021.10.0
Closes #19168