wxWidgets intial recipe #21353

gmeeker · 2023-11-24T20:11:31Z

Specify library name and version: wxwidgets/3.2.3

Implements #5190 #19991 #20092
Requested by #621

This is a new recipe to CCI. It's an updated version from bincrafters but ported to Conan v2 with additional fixes.

https://github.com/bincrafters/community/tree/main/recipes/wxwidgets

Also unmerged GTK3 work from here (using GTK from Conan recipe):

GTK support is currently a draft but macOS and Windows seem usable. Any feedback appreciated. For example, do we need anything older than 3.2.3 here?

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

…e; ported from bincrafters to v2

Co-authored-by: Martin Valgur <[email protected]>

gmeeker · 2024-08-06T00:14:10Z

Using GTK from Conan is still not working because that recipe doesn't support Conan v2 yet.
I'm not sure what would happen if you mix a Conan built GTK with system WebKitGTK (and writing a recipe for that looks even more daunting).
wxWidgets is still GTK3 only but I don't think that affects any of this.
I'm not able to use Conan cairo with system GTK. I'm getting missing glib symbols (maybe mixing system + built glibs).

So I'm not sure if this will be solved anytime soon.

czoido · 2024-08-19T11:37:57Z

Hi @gmeeker,
Thanks a lot for the contribution, I'm pushing some changes to simplify the options (if it's needed in the future we can always put them back), relying on defaults for the moment and also removing the gtk option until we have a gtk recipe compatible with Conan 2 (I'm working on some changes for the PR open, so I hope it will be soon)

conan-center-bot · 2024-08-19T14:22:58Z

Conan v1 pipeline ✔️

All green in build 7 (a0e7e28a61ff0c46d266f96f3c56148352679a84):

wxwidgets/3.2.5:
All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (a0e7e28a61ff0c46d266f96f3c56148352679a84):

wxwidgets/3.2.5:
All packages built successfully! (All logs)

SpaceIm · 2024-09-22T15:48:18Z

Why is there ninja in build requirements? Putting ninja in build requirement of a recipe doesn't mean that it will be used as CMake generator. It would also require to force tc.generator = "Ninja" in generate(), but it's missing.
Builds pass, and Ninja is not used at all as we can see in build logs, so I think it can be removed.

SpaceIm · 2024-09-22T16:09:21Z

recipes/wxwidgets/all/conanfile.py

+        if self.options.get_safe("secretstore"):
+            packages.append("libsecret-1-dev")


There is libsecret in conancenter.

I'm surprised by this recipe. I thought it was forbidden to have system requirements explicitly requested in conancenter recipes (except for a "system" recipe).

Same question. How did this get past hook checks and human reviews?

* (conan-io#5190) (conan-io#19991) (conan-io#20092) new wxwidgets recipe; ported from bincrafters to v2 * [wxwidgets] use f-strings * [wxwidgets] remove glib override * [wxwidgets] Add gtk option and default to gtk/system for now. * [wxwidgets] update system_requirements * [wxwidgets] Adding 3.2.4 * [wxwidgets] fix errors from gtk and opengl options * [wxwidgets] default to GTK2 to match gtk/system binaries in CCI * [wxwidgets] fix fPIC handling * [wxwidgets] fix nanosvg usage * [wxwidgets] fix cmake dependencies * [wxwidgets] don't package cmake files * [wxwidgets] fix macOS patching * [wxwidgets] use is_msvc * [wxwidgets] removing 3.1.x versions * [wxwidgets] Adding libraries to cpp_info to fix hook warnings. * remove older versions, add version ranges * fix config.yml for wxwidgets * add version range for expat * Update recipes/wxwidgets/all/conanfile.py Co-authored-by: Martin Valgur <[email protected]> * [wxwidgets] set gtk, xkbcommon options * simplify recipe options * wip * simplify * remove comment * put jpeg option back --------- Co-authored-by: memsharded <[email protected]> Co-authored-by: czoido <[email protected]> Co-authored-by: Martin Valgur <[email protected]>

(conan-io#5190) (conan-io#19991) (conan-io#20092) new wxwidgets recip…

bb41a51

…e; ported from bincrafters to v2

prince-chrismc mentioned this pull request Nov 24, 2023

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

conan-center-bot added the Failed label Nov 24, 2023

This comment has been minimized.

Sign in to view

Merge branch 'master' into feature/wxwidgets

1877426

This comment has been minimized.

Sign in to view

[wxwidgets] use f-strings

3132a4b

This comment has been minimized.

Sign in to view

[wxwidgets] remove glib override

22341bb

This comment has been minimized.

Sign in to view

[wxwidgets] Add gtk option and default to gtk/system for now.

583bc6a

conan-center-bot added the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 25, 2023

This comment has been minimized.

Sign in to view

[wxwidgets] update system_requirements

f825195

This comment has been minimized.

Sign in to view

gmeeker added 2 commits November 25, 2023 13:22

[wxwidgets] Adding 3.2.4

5ea5907

[wxwidgets] fix errors from gtk and opengl options

85b3c68

This comment has been minimized.

Sign in to view

[wxwidgets] default to GTK2 to match gtk/system binaries in CCI

b14bb1f

conan-center-bot removed the Missing dependencies Build failed due missing dependencies in Conan Center label Nov 25, 2023

This comment has been minimized.

Sign in to view

gmeeker added 3 commits November 25, 2023 21:29

[wxwidgets] fix fPIC handling

57cc5fc

[wxwidgets] fix nanosvg usage

94cf1af

[wxwidgets] fix cmake dependencies

e9e9b05

This comment has been minimized.

Sign in to view

gmeeker added 3 commits November 26, 2023 15:42

[wxwidgets] don't package cmake files

7503679

[wxwidgets] fix macOS patching

60e7035

[wxwidgets] use is_msvc

697dd84

This comment has been minimized.

Sign in to view

[wxwidgets] removing 3.1.x versions

699c539

czoido self-assigned this Aug 3, 2024

Update recipes/wxwidgets/all/conanfile.py

febd154

Co-authored-by: Martin Valgur <[email protected]>

This comment has been minimized.

Sign in to view

[wxwidgets] set gtk, xkbcommon options

106a8c4

This comment has been minimized.

Sign in to view

czoido added 4 commits August 19, 2024 11:58

simplify recipe options

c54c178

wip

2550696

simplify

8c2380a

remove comment

81df735

conan-center-bot added Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 19, 2024

This comment has been minimized.

Sign in to view

put jpeg option back

a0e7e28

conan-center-bot removed Failed Missing dependencies Build failed due missing dependencies in Conan Center labels Aug 19, 2024

memsharded approved these changes Aug 19, 2024

View reviewed changes

czoido approved these changes Aug 19, 2024

View reviewed changes

conan-center-bot merged commit e18fb92 into conan-io:master Aug 19, 2024
12 checks passed

SpaceIm reviewed Sep 22, 2024

View reviewed changes

This was referenced Sep 23, 2024

wxWidgets fails when cross-compiling; bincrafters/community#1433

Closed

Use Conan GTK3 requirement; WebKitGTK isn't available. bincrafters/community#1435

Closed

Bincrafters Conan repo is down for good bincrafters/community#1456

Open

Croydon mentioned this pull request Oct 2, 2024

[request] wxWidgets/3.2.1 #20092

Open

Croydon mentioned this pull request Oct 22, 2024

KB-H032 hook is outdated conan-io/hooks#510

Open

Croydon mentioned this pull request Nov 29, 2024

[request] wxwidgets/3.2.2.1 #19991

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wxWidgets intial recipe #21353

wxWidgets intial recipe #21353

gmeeker commented Nov 24, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gmeeker commented Aug 6, 2024

This comment has been minimized.

czoido commented Aug 19, 2024

This comment has been minimized.

conan-center-bot commented Aug 19, 2024

SpaceIm commented Sep 22, 2024 •

edited

Loading

SpaceIm Sep 22, 2024 •

edited

Loading

Croydon Sep 23, 2024

		if self.options.get_safe("secretstore"):
		packages.append("libsecret-1-dev")

wxWidgets intial recipe #21353

wxWidgets intial recipe #21353

Conversation

gmeeker commented Nov 24, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

gmeeker commented Aug 6, 2024

This comment has been minimized.

czoido commented Aug 19, 2024

This comment has been minimized.

conan-center-bot commented Aug 19, 2024

Conan v1 pipeline ✔️

Conan v2 pipeline ✔️

SpaceIm commented Sep 22, 2024 • edited Loading

SpaceIm Sep 22, 2024 • edited Loading

Choose a reason for hiding this comment

Croydon Sep 23, 2024

Choose a reason for hiding this comment

SpaceIm commented Sep 22, 2024 •

edited

Loading

SpaceIm Sep 22, 2024 •

edited

Loading