Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eigen: fix pkg_config name and CMake target #2155

Merged
merged 2 commits into from
Jul 9, 2020
Merged

eigen: fix pkg_config name and CMake target #2155

merged 2 commits into from
Jul 9, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 8, 2020

Specify library name and version: eigen/3.3.7

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jul 8, 2020

pkg_config name: https://gitlab.com/libeigen/eigen/-/blob/3.3.7/CMakeLists.txt#L429

@conan-center-bot
Copy link
Collaborator

All green in build 1 (2a0e2d580d84a8eb13352d584c533ae4bdd1bf98)! 😊

@SpaceIm SpaceIm mentioned this pull request Jul 8, 2020
Closed
uilianries
uilianries approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uilianries uilianries requested review from jgsogo and SSE4 July 8, 2020 13:38
@SSE4 SSE4 merged commit de344e9 into conan-io:master Jul 9, 2020
@SpaceIm SpaceIm deleted the fix/eigen-target branch July 9, 2020 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@jgsogo jgsogo jgsogo approved these changes

@uilianries uilianries uilianries approved these changes

Assignees

@SSE4 SSE4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceIm @conan-center-bot @SSE4 @jgsogo @uilianries