winpcap: add winpcap/4.1.3 recipe #6348

madebr · 2021-07-15T04:15:04Z

Specify library name and version: winpcap/4.1.3

Tested on Linux
On Windows:
- Needs the Windows DDK (=Driver Development Kit)
- Fails to build on my machine because of a missing header inside the DDK (MSVC cannot find ndis/types.h). Feedback welcome.
- Not tested with mingw
other operating systems: not tested. The recipe raises an error. PRs are welcome to add macos support.

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

SpaceIm · 2021-07-15T09:18:16Z

Did you write all the CMake files from scratch or does it come from a fork?

madebr · 2021-07-15T11:11:33Z

I wrote them from scratch.
FindWDK.cmake is the only file I copied from the interwebs. The file has its license at the top.

madebr · 2021-07-15T11:15:28Z

I need to investigate why Windows is not built on c3i.

madebr · 2021-07-15T13:00:32Z

recipes/winpcap/all/conanfile.py

+    def config_options(self):
+        if self.settings.os == "Windows":
+            del self.options.fPIC
+            self.options.turbocap = True
+            self.options.capture_type = "win32"
+        elif self.settings.os == "Linux":
+            self.options.capture_type = "linux"
+        if self.settings.os != "Linux":
+            del self.options.bluetooth
+            del self.options.usb_sniffing
+            del self.options.usb_sniffing_device


@jgsogo
c3i fails to build on MSVC@Windows.
See #6348 (comment)
c3i says my recipe emits an ConanInvalidConfiguration when os=Windows (the logs don't tell me).

The values inside default_options are indeed invalid on Windows,
but they are converted to valid options in config_options.

recipes/winpcap/all/cmake/packetntx.cmake

madebr · 2021-07-15T13:05:44Z

recipes/winpcap/all/test_package/test_package.c

+/* prototype of the packet handler */
+void packet_handler(u_char *param, const struct pcap_pkthdr *header, const u_char *pkt_data);
+
+int main()


This test package is interactive. It should be made non-interactive.

FIXME: borrow test package from bincrafters/community#1395

SpaceIm · 2021-07-15T13:35:24Z

recipes/winpcap/all/conanfile.py

+        if tools.os_info.is_windows:
+            self.build_requires("winflexbison/2.5.24")
+        else:
+            self.build_requires("bison/3.7.1")
+            self.build_requires("flex/2.6.4")


here is the issue with windows, because it is first evaluated on a linux machine

But it's a build requirement. I thought those didn't influence the package id?

I think it should be more robust (2 profiles in the first condition, 1 profile in the second):

if (hasattr(self, "settings_build") and self.settings_build.os == "Windows) or (not hasattr(self, "settings_build") and self.settings.os == "Windows")

When 1 profile will behave like 2 profiles, it could be replaced by self.settings_build.os == "Windows

Thanks! Let's try the settings_build approach.

But it's a build requirement. I thought those didn't influence the package id?

Not related to package id. In CI of CCI, a linux machine runs some tests first, and tools.os_info.is_windows is always False. @jgsogo can explain better than me.

Yes. In CCI we first compute the packageIDs for all the configurations (this computation runs on a Linux machine) so we can remove duplicates and those that are invalid-config. Then, we will use win/linux/mac nodes to build the libraries.

If (running in Linux) Conan computes an invalid-config for a given configuration (a Windows one) we won't try to build that configuration, we will just report it is invalid. For this reason, it is very important that everything used in a recipe is provided as input (via profiles) and nothing is guessed... and this is mandatory for the source lines that are executed while computed the package-id in the Linux machine (tomorrow it could be a Windows node or Macos).

Although build-requires will not affect the package-id, while computing if it is a valid configuration, we also take into account the build-requires that will be required to build. If these build-requires are not available, then the configuration is also removed.

TL;DR; toos.os_info is evil outside build step (build() always takes place in the build machine).

Thanks for the reply.
I know you had to write this message a lot already. 😅

Should this go in the FAQ?

See conan-io/hooks#320 for a first attempt to implement this into a hook.

Amazing! this is supper helpful to have and know

conan-center-bot · 2021-07-15T14:01:40Z

Failure in build 7 (5b2a09a45baed1f085aca5d534f7357c8d45d3a6):

winpcap/4.1.3@:
CI failed to create some packages (All logs)

Logs for packageID e5375efbdfdd123f7f396cfe34b84c596e22896e:

[settings]
arch=x86_64
arch_build=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MT
compiler.version=14
os=Windows
os_build=Windows
[options]
winpcap:shared=False

[...]
winflexbison/2.5.24: Setting YACC environment variable: C:/J/w/BuildSingleReference@2/.conan/data/winflexbison/2.5.24/_/_/package/df81ad20137149d7a51276fd3e24009b45e5964a/bin/win_bison -y
[HOOK - conan-center.py] post_package_info(): [CMAKE FILE NOT IN BUILD FOLDERS (KB-H019)] OK
[HOOK - conan-center.py] post_package_info(): [LIBRARY DOES NOT EXIST (KB-H054)] OK
winpcap/4.1.3: Applying build-requirement: winflexbison/2.5.24
winpcap/4.1.3: Copying sources to build folder
winpcap/4.1.3: Building your package in C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e
winpcap/4.1.3: Generator cmake created conanbuildinfo.cmake
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] 'fPIC' option not found
[HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
winpcap/4.1.3: Calling build()

----Running------
> cd C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e && cmake -G "Visual Studio 14 2015 Win64" -DCONAN_LINK_RUNTIME="/MT" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="Visual Studio" -DCONAN_COMPILER_VERSION="14" -DCONAN_CXX_FLAGS="/MP16" -DCONAN_C_FLAGS="/MP16" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\package\e5375efbdfdd123f7f396cfe34b84c596e22896e" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DWINPCAP_CAPTURE_TYPE="win32" -DWINPCAP_REMOTE="True" -DWINPCAP_TURBOCAP="True" -DWINPCAP_BLUETOOTH="False" -DWINPCAP_USB="False" -DWINPCAP_USB_DEVICE="" -Wno-dev C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e
-----------------
-- Selecting Windows SDK version 10.0.14393.0 to target Windows 10.0.17763.
-- The C compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/x86_amd64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Conan: called by CMake conan helper
-- Conan: called inside local cache
-- Conan: Adjusting output directories
-- Conan: Using cmake global configuration
-- Conan: Adjusting default RPATHs Conan policies
-- Conan: Adjusting language standard
-- This project seems to be plain C, using 'MSVC' compiler
-- Configuring incomplete, errors occurred!
See also "C:/J/w/BuildSingleReference@2/.conan/data/winpcap/4.1.3/_/_/build/e5375efbdfdd123f7f396cfe34b84c596e22896e/CMakeFiles/CMakeOutput.log".
winpcap/4.1.3: 
winflexbison/2.5.24: WARN: Lib folder doesn't exist, can't collect libraries: C:\J\w\BuildSingleReference@2\.conan\data\winflexbison\2.5.24\_\_\package\df81ad20137149d7a51276fd3e24009b45e5964a\lib
winpcap/4.1.3: WARN: Build folder is dirty, removing it: C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e
CMake Error at C:/Program Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message):
  Could NOT find WDK (missing: WDK_LATEST_NTDDK_FILE)
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:393 (_FPHSA_FAILURE_MESSAGE)
  cmake/FindWDK.cmake:49 (find_package_handle_standard_args)
  cmake/packetntx.cmake:8 (find_package)
  CMakeLists.txt:12 (include)


winpcap/4.1.3: ERROR: Package 'e5375efbdfdd123f7f396cfe34b84c596e22896e' build failed
winpcap/4.1.3: WARN: Build folder C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e
ERROR: winpcap/4.1.3: Error in build() method, line 124
	cmake = self._configure_cmake()
while calling '_configure_cmake', line 115
	self._cmake.configure()
	ConanException: Error 1 while executing cd C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e && cmake -G "Visual Studio 14 2015 Win64" -DCONAN_LINK_RUNTIME="/MT" -DCONAN_IN_LOCAL_CACHE="ON" -DCONAN_COMPILER="Visual Studio" -DCONAN_COMPILER_VERSION="14" -DCONAN_CXX_FLAGS="/MP16" -DCONAN_C_FLAGS="/MP16" -DBUILD_SHARED_LIBS="OFF" -DCMAKE_INSTALL_PREFIX="C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\package\e5375efbdfdd123f7f396cfe34b84c596e22896e" -DCMAKE_INSTALL_BINDIR="bin" -DCMAKE_INSTALL_SBINDIR="bin" -DCMAKE_INSTALL_LIBEXECDIR="bin" -DCMAKE_INSTALL_LIBDIR="lib" -DCMAKE_INSTALL_INCLUDEDIR="include" -DCMAKE_INSTALL_OLDINCLUDEDIR="include" -DCMAKE_INSTALL_DATAROOTDIR="share" -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY="ON" -DCONAN_EXPORTED="1" -DWINPCAP_CAPTURE_TYPE="win32" -DWINPCAP_REMOTE="True" -DWINPCAP_TURBOCAP="True" -DWINPCAP_BLUETOOTH="False" -DWINPCAP_USB="False" -DWINPCAP_USB_DEVICE="" -Wno-dev C:\J\w\BuildSingleReference@2\.conan\data\winpcap\4.1.3\_\_\build\e5375efbdfdd123f7f396cfe34b84c596e22896e

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

seladb · 2021-07-16T01:01:39Z

recipes/winpcap/all/conanfile.py

+            del self.options.fPIC
+            self.options.turbocap = True
+            self.options.capture_type = "win32"
+        elif self.settings.os == "Linux":


@madebr WinPcap is for Windows only. It's actually a Windows port of libpcap which is not available on Windows. For Linux/macOS the libpcap Conan package should be used

Then I'll look into stripping everything non-Windows related.

prince-chrismc · 2021-07-20T12:48:33Z

recipes/winpcap/all/patches/0001-linux-patch.cmake

+ #ifdef HAVE_REMOTE
+ #include <pcap-remote.h>
+ #endif
+#ifdef NEED_LINUX_SOCKIOS_H


Bad file extension

madebr · 2021-07-20T16:12:18Z

recipes/winpcap/all/conanfile.py

+            raise ConanInvalidConfiguration("missing turbocap cci recipe")
+
+    def build_requirements(self):
+        if self._build_os == "Windows":


FIXME: add _settings_build property method

stale · 2021-08-20T11:09:26Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2021-09-19T12:01:53Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

seladb · 2021-09-20T00:19:08Z

@madebr the PR was closed :(
Any chance you'll have time to complete this work?

ghost mentioned this pull request Jul 15, 2021

[service] Potentially conflicting recipes #3571

Closed

This comment has been minimized.

Sign in to view

conan-center-bot added the Failed label Jul 15, 2021

madebr force-pushed the winpcap_recipe branch from 3d57d22 to 15204d6 Compare July 15, 2021 04:16

This comment has been minimized.

Sign in to view

madebr force-pushed the winpcap_recipe branch 2 times, most recently from 37fd012 to 8642532 Compare July 15, 2021 04:23

winpcap: add winpcap/4.1.3 recipe

66a4d8b

madebr force-pushed the winpcap_recipe branch from 8642532 to 66a4d8b Compare July 15, 2021 04:23

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Jul 15, 2021

This comment has been minimized.

Sign in to view

conan-center-bot removed Unexpected Error Failed labels Jul 15, 2021

github-actions bot mentioned this pull request Jul 15, 2021

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

madebr commented Jul 15, 2021

View reviewed changes

recipes/winpcap/all/cmake/packetntx.cmake Outdated Show resolved Hide resolved

winpcap: target of windows driver is packet

65af5cc

madebr commented Jul 15, 2021

View reviewed changes

SpaceIm reviewed Jul 15, 2021

View reviewed changes

winpcap: use settings.build if available

5b2a09a

conan-center-bot added the Failed label Jul 15, 2021

madebr mentioned this pull request Jul 15, 2021

add winpcap/4.1.2 bincrafters/community#1395

Closed

seladb reviewed Jul 16, 2021

View reviewed changes

SpaceIm mentioned this pull request Jul 16, 2021

add libnet/1.2 #5977

Merged

4 tasks

prince-chrismc reviewed Jul 20, 2021

View reviewed changes

madebr commented Jul 20, 2021

View reviewed changes

madebr mentioned this pull request Jul 20, 2021

Disallow tools.os_info and platform in requirements/build_requirements/config_options/configure/validate conan-io/hooks#320

Merged

garethsb mentioned this pull request Aug 3, 2021

Refactor CMake files to better support nmos-cpp as a library garethsb/nmos-cpp#2

Closed

stale bot added the stale label Aug 20, 2021

seladb mentioned this pull request Aug 25, 2021

[request] PcapPlusPlus/18.08 #5501

Closed

stale bot closed this Sep 19, 2021

madebr mentioned this pull request Sep 21, 2021

Add gsl/2.7 #6098

Merged

4 tasks

uilianries mentioned this pull request Sep 16, 2022

Add npcap package #12899

Merged

4 tasks

valgur mentioned this pull request Jan 26, 2024

Stale recipe PRs possibly worth another look #22553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

winpcap: add winpcap/4.1.3 recipe #6348

winpcap: add winpcap/4.1.3 recipe #6348

madebr commented Jul 15, 2021 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Jul 15, 2021 •

edited

Loading

madebr commented Jul 15, 2021 •

edited

Loading

madebr commented Jul 15, 2021 •

edited

Loading

madebr Jul 15, 2021 •

edited

Loading

madebr Jul 15, 2021

madebr Jul 20, 2021

SpaceIm Jul 15, 2021 •

edited

Loading

madebr Jul 15, 2021

SpaceIm Jul 15, 2021 •

edited

Loading

madebr Jul 15, 2021

SpaceIm Jul 15, 2021

jgsogo Jul 16, 2021

madebr Jul 16, 2021

prince-chrismc Jul 20, 2021

madebr Jul 20, 2021

prince-chrismc Jul 21, 2021

conan-center-bot commented Jul 15, 2021

seladb Jul 16, 2021

madebr Jul 16, 2021

prince-chrismc Jul 20, 2021

madebr Jul 20, 2021

stale bot commented Aug 20, 2021

stale bot commented Sep 19, 2021

seladb commented Sep 20, 2021

winpcap: add winpcap/4.1.3 recipe #6348

winpcap: add winpcap/4.1.3 recipe #6348

Conversation

madebr commented Jul 15, 2021 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

SpaceIm commented Jul 15, 2021 • edited Loading

madebr commented Jul 15, 2021 • edited Loading

madebr commented Jul 15, 2021 • edited Loading

madebr Jul 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Jul 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SpaceIm Jul 15, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Jul 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Aug 20, 2021

stale bot commented Sep 19, 2021

seladb commented Sep 20, 2021

madebr commented Jul 15, 2021 •

edited

Loading

SpaceIm commented Jul 15, 2021 •

edited

Loading

madebr commented Jul 15, 2021 •

edited

Loading

madebr commented Jul 15, 2021 •

edited

Loading

madebr Jul 15, 2021 •

edited

Loading

SpaceIm Jul 15, 2021 •

edited

Loading

SpaceIm Jul 15, 2021 •

edited

Loading