Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture errors from Conan and log them to output window and log file #125

Merged
merged 4 commits into from
Jul 15, 2019

Conversation

jgsogo
Copy link

@jgsogo jgsogo commented Jun 28, 2019

Capture the errors from Conan output and log them to all available windows.

It also modifies the return type from ConanRunner, probably it is better to return just the ProcessStartInfo and let the consumer decide to run the command synchronously or not.

closes #118

@jgsogo jgsogo added this to the 1.2.0 milestone Jun 28, 2019
@jgsogo jgsogo requested a review from SSE4 June 28, 2019 15:10
@SSE4 SSE4 marked this pull request as ready for review July 8, 2019 10:37
@jgsogo
Copy link
Author

jgsogo commented Jul 15, 2019

Nice improve over my code 😊

@jgsogo jgsogo merged commit a913ea0 into conan-io:dev Jul 15, 2019
@jgsogo jgsogo deleted the issue/118-error-messages branch July 15, 2019 15:42
@jgsogo jgsogo mentioned this pull request Jul 23, 2019
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error messaging for
2 participants