Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Visual Studio 2022 #9370
Feature: Visual Studio 2022 #9370
Changes from 1 commit
3e169b1
11dfcb3
82cbef1
afaa31e
6f75844
c534e6e
dc2f43d
57b7d90
b740d41
cbfc47a
c2bcb73
cd0181c
e4b05eb
768b0db
d136122
9382622
110d8fa
df93899
a3ba45f
5a8aa05
5f4cd9e
6b73f7b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@memsharded there is some important thing, which concerns me a lot. it's not directly related to VS2022, but to
msvc
compiler versioning scheme in general.I just realized it than I've seen we maybe need to add
19.29
to the list.check out https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=vs-2019
TLDR:
_MSC_VER
19.28
maps to the two versions (16.8 and 16.9), and19.30
maps to the two versions as well (16.10 and 16.11)our current versioning scheme won't be able to express that.
maybe we need to create a new issue and discuss if we want to change? since
msvc
is experimental, it's not late.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we are ok with
msvc.version
right? I mean if19.28
maps both to16.8
and16.9
means that both versions "use the same compiler version", so the model formsvc
is good. The reverse mapping can choose the version we want. How do you think this could affect? @SSE4There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it may hit some users who use LTTG and binaries aren't compatible for
16.8
vs16.9
perhaps, they will need to add more sub-settings, like
19.28.29500
?more info is by links from #3573 (comment):
https://developercommunity.visualstudio.com/t/the-169-cc-compiler-still-uses-the-same-version-nu/1335194#T-N1337120
https://developercommunity.visualstudio.com/t/how-to-select-vs-168-compiler-with-vcvars-after-up/1359197?from=email
it's irrelevant for vs2022 anyway, but maybe we can discuss if it's an issue to be addressed in conan.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I see. What a mess...