Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for image digest and spare roundtrip to ... #231

Closed
wants to merge 1 commit into from
Closed

Add support for image digest and spare roundtrip to ... #231

wants to merge 1 commit into from

Conversation

achawki
Copy link

@achawki achawki commented Jul 31, 2018

... registry if digest is set

  • image digests are immutable, no need to explicitly check it or for new versions
  • in case of docker registry downtime, job would be still able to be scheduled in case digest is set

... registry if digest is set
- image digests are immutable, no need to explicitly check it or for new versions
- in case of docker registry downtime, job would be still able to be scheduled in case digest is set
@pivotal-issuemaster
Copy link

@achawki Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@vito
Copy link
Member

vito commented Jul 31, 2018

Thanks for submitting this!

I mentioned concourse/concourse#2439 already in the other PR (#229), but there's actually another issue we're planning which should satisfy this: concourse/concourse#2443

These are all coming up very soon in the "Core" backlog (we've actually just started on #2439), so I'm inclined to close this and #229 and just wait for those core features to be done, since they'll enable this pattern for all resource types without requiring any changes. Does that sound OK?

@achawki
Copy link
Author

achawki commented Jul 31, 2018

@vito thanks, I was not aware of concourse/concourse#2443 or that this functionality was planned.
Yeah sounds good. I'll close this PR then.

@achawki achawki closed this Jul 31, 2018
@vito
Copy link
Member

vito commented Jul 31, 2018

@achawki No problem! I actually wrote it after your PR, heh. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants