Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark spdlog builds 1.10.0-*_1 as broken to ABI breakage #501

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 25, 2022

The spdlog builds 1.10.0-*_1 have a different ABI w.r.t. 1.10.0-*_0, resulting in runtime errors if 1.10.0-*_1 is installed with libraries and executables that were builded and linked against 1.10.0-*_0, see conda-forge/spdlog-feedstock#53 for more info.

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • Make sure your package is in the right spot (broken/* for adding the
    broken label, not_broken/* for removing the broken label, or token_reset/*
    for token resets)
  • Added a description of the problem with the package in the PR description.
  • Added links to any relevant issues/PRs in the PR description.
  • Pinged the team for the package for their input.

@traversaro
Copy link
Contributor Author

@conda-forge/spdlog if you agree a consensus on conda-forge/spdlog-feedstock#53, we can ping core to get this PR merged.

@traversaro
Copy link
Contributor Author

traversaro commented Oct 27, 2022

It seems that the only active members of @conda-forge/spdlog active is @bluescarni that in conda-forge/spdlog-feedstock#53 (comment) confirmed that this is the way to go. @conda-forge/core the PR is ready for review (fyi @wolfv this should unblock the robostack rebuilds).

@beckermr beckermr merged commit 50050d9 into conda-forge:main Oct 27, 2022
@traversaro
Copy link
Contributor Author

Thanks @beckermr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants