Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove broken bw2calc (label dev) Packages #802

Closed
wants to merge 1 commit into from
Closed

Remove broken bw2calc (label dev) Packages #802

wants to merge 1 commit into from

Conversation

michaelweinold
Copy link

Guidelines for marking packages as broken:

  • We prefer to patch the repo data (see here)
    instead of marking packages as broken. This alternative workflow makes environments more reproducible.
  • Packages with requirements/metadata that are too strict but otherwise work are
    not technically broken and should not be marked as such.
  • Packages with missing metadata can be marked as broken on a temporary basis
    but should be patched in the repo data and be marked unbroken later.
  • In some cases where the number of users of a package is small or it is used by
    the maintainers only, we can allow packages to be marked broken more liberally.
  • We (conda-forge/core) try to make a decision on these requests within 24 hours.

What will happen when a package is marked broken?

  • Our bots will add the broken label to the package. The main label will remain on the package and this is normal.
  • Our bots will rebuild our repodata patches to remove this package from the repodata.
  • In a few hours after the anaconda.org CDN picks up the new patches, you will no longer be able to install the package from the main channel.

Checklist:

  • I want to mark a package as broken (or not broken):
    • Make sure your package is in the right spot (broken/* for adding the
      broken label, not_broken/* for removing the broken label, or token_reset/*
      for token resets)
    • Added a description of the problem with the package in the PR description.
    • Pinged the team for the package for their input.

Description

The dev versions of bw2calc were added to the conda-forge channel under the dev label. Unfortunately, the package was not released as noarch. This complicates downstream development efforts depending on this package. Related discussions in these PRs:

The platform specific dev versions (cf. the broken/bw2calc_broken.txt file) should be removed entirely. They are to be replaced with a noarch version.

🔔 @conda-forge/bw2calc

@michaelweinold michaelweinold requested a review from a team as a code owner August 24, 2023 05:04
@michaelweinold
Copy link
Author

@conda-forge/core, this is ready for review. Not sure why the checks are failing. I formatted the file exactly like eg. https://github.com/conda-forge/admin-requests/pull/686/files, where the checks are passing.

@ocefpaf
Copy link
Member

ocefpaf commented Aug 24, 2023

I wonder if it is the fact that those are in the dev label that is causing this error. I'm not sure our automated labeling system covers that case.

@xhochy
Copy link
Member

xhochy commented Aug 24, 2023

I think, we can only mark packages on main as broken. Also, the channel should not be used in general but artefacts should use their own <name>_dev channel for development releases. Otherwise, an enduser cannot select from which artefact they want to try out dev releases.

@michaelweinold
Copy link
Author

Also, the channel should not be used in general but artefacts should use their own _dev channel for development releases. Otherwise, an enduser cannot select from which artefact they want to try out dev releases.

Are you saying we should have created a branch bw2calc_dev instead of dev in the bw2calc repo?

We successfully installed the package by specifying the channel+label in the package specs of the usual environment files:

- https://conda.anaconda.org/conda-forge/label/bw2calc_dev::bw2calc=2.0.dev14

Maybe I'm not following - in any case, we tried to follow CFEP-05 to the letter.

@h-vetinari
Copy link
Member

Yes, the automation here only works for main. For marking things in different labels as broken it needs someone from core (and in the cf-org on https://anaconda.org/conda-forge) to mark them broken by hand.

@h-vetinari
Copy link
Member

The label is already bw2calc_dev, as it should be.

Unfortunately, the package was not released as noarch. This complicates downstream development efforts depending on this package.

Now that you have a noarch build (2.0.dev14), why do you still need to mark 2.0.dev13 as broken? The solver should already pull in the newer one.

@michaelweinold michaelweinold closed this by deleting the head repository Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants