Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Rebuild for orc 2.1.0 #1697

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update orc210.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/13137423292 - please use this URL for debugging.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13137711119. Examine the logs at this URL for more detail.

@h-vetinari h-vetinari changed the title Rebuild for orc 2.1.0 [main] Rebuild for orc 2.1.0 Feb 4, 2025
@h-vetinari
Copy link
Member

h-vetinari commented Feb 4, 2025

@kou, any idea why a previously working recipe for unchanged versions (affects all versions we build: 19.x, 18.x, 17.x, 16.x) would suddenly start failing over some aws config:

CMake Error at cmake_modules/ThirdpartyToolchain.cmake:4941 (include):
  include could not find requested file:

    AWSSDKVariables
Call Stack (most recent call first):
  CMakeLists.txt:544 (include)


CMake Error at cmake_modules/ThirdpartyToolchain.cmake:310 (find_package):
  By not providing "FindAWSSDKAlt.cmake" in CMAKE_MODULE_PATH this project
  has asked CMake to find a package configuration file provided by
  "AWSSDKAlt", but CMake did not find one.

  Could not find a package configuration file provided by "AWSSDKAlt" with
  any of the following names:

    AWSSDKAltConfig.cmake
    awssdkalt-config.cmake

  Add the installation prefix of "AWSSDKAlt" to CMAKE_PREFIX_PATH or set
  "AWSSDKAlt_DIR" to a directory containing one of the above files.  If
  "AWSSDKAlt" provides a separate development package or SDK, be sure it has
  been installed.
Call Stack (most recent call first):
  cmake_modules/ThirdpartyToolchain.cmake:5324 (resolve_dependency)
  CMakeLists.txt:544 (include)

This file ($SP_DIR/cmake_modules/AWSSDKVariables.cmake) is actually something pyarrow has been shipping itself, so it's not even that the change would be explainable by a new version of aws-sdk-cpp or cmake...?

@h-vetinari
Copy link
Member

Ping @kou @pitrou @raulcd how to fix the AWSSDKVariables issue that cropped up

@raulcd
Copy link
Member

raulcd commented Feb 11, 2025

Strangely enough, it seems the orc update has something to do with it because I triggered a no change build here:

And it's able to build AWS SDK without problems.
Could it be related to this? This fix is not part of 2.1.0

FYI @wgtmac

@raulcd
Copy link
Member

raulcd commented Feb 11, 2025

Yes, we had this PR for Arrow to use ORC 2.1.0, which is applying that patch when building orc from source:

@wgtmac
Copy link

wgtmac commented Feb 11, 2025

It should be highly relevant. Apache ORC 2.1.1 is planned in this April. Should we wait for it or get it released ASAP? @raulcd @h-vetinari

cc @dongjoon-hyun @williamhyun

@raulcd
Copy link
Member

raulcd commented Feb 12, 2025

I am unsure whether this should be fixed on the ORC recipe or we want to add the patch from the PR I pointed above here. I suppose this could happen for other projects, right? @h-vetinari I am happy to temporarily add the patch here if you think this should be the approach.

@h-vetinari
Copy link
Member

We'd need to patch orc itself, if we're comfortable with backporting the patch instead of waiting for v2.1.1. If we don't want to backport this to orc more generally, then version 2.1.0 is essentially not usable, and we'll just have to sit it out until the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants