Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch migration #20

Merged
merged 11 commits into from
Oct 29, 2021
Merged

aarch migration #20

merged 11 commits into from
Oct 29, 2021

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented May 18, 2021

Closes #19

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

@hmaarrfk hmaarrfk mentioned this pull request May 18, 2021
@hmaarrfk
Copy link
Contributor Author

well the builds are moving, i can't debug why it is actually failing the tests. but this should help the migration.

@rhattersley
Copy link

Thanks @hmaarrfk 👍

Re: https://travis-ci.com/github/conda-forge/check-feedstock/builds/226195433#L1443
Are you able to tweak the build script to print the contents of tests/test-suite.log?

@hmaarrfk
Copy link
Contributor Author

I'm not sure if i am outputing the results of the correct file, but feel free to update the build.sh file.

@rhattersley
Copy link

Finally got a chance to spend a little time on this.

@hmaarrfk - thanks for adding the output of the test suite.

From the test results we can see test_ck_assert_ldouble_eq_tol is passing when it should fail. (With the knock-on effect of causing other tests to fail as the arrays of results and expected results are out of alignment.) The check test suite has already been fixed for this PPC-specific issue: libcheck/check#322, but they have yet to make a new release. (No releases since Aug 2020 and sadly not much of a response to their attempts to recruit on the mailing list or GitHub issue.)

@rhattersley
Copy link

The fix to the tests is pretty simple, so we could update the conda recipe to apply it as a patch file:

  1. Create patch file from libcheck/check repo: git format-patch -1 4fbe702fa4f35bee8a90512f9f59d1441c4ae82e
  2. Add resulting patch file to this feedstock repo.
  3. Reference the patch file in recipe/meta.yaml:
source:
  url: ...
  sha256: ...
  patches:
    - <path-to-patch-file-in-this-repo>

@hmaarrfk - are you OK to make that change?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jul 5, 2021

Thanks for making it easy.

Feel free to make pushes to my branch in case i'm not responsive. Sometimes I just try to push aarch migration forward if i have an hour in my day,.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Jul 5, 2021

May I add myself as a maintainer to this?

@andfoy
Copy link

andfoy commented Oct 19, 2021

@hmaarrfk, do you know what is missing from this PR? The aarch64 packages are required by pulseaudio, which in turn are required by Qt 5.15, could I help in any way?

@hmaarrfk
Copy link
Contributor Author

@conda-forge-admin please rerender

@hmaarrfk
Copy link
Contributor Author

probably ready.

@andfoy
Copy link

andfoy commented Oct 25, 2021

@rhattersley, is it possible to merge this one? The aarch64 packages are required by pulseaudio, which in turn are required by Qt 5.15.2

@andfoy
Copy link

andfoy commented Oct 28, 2021

@conda-forge/core, is is possible to merge this PR? Right now we require it to finish compiling Qt 5.15.2 in aarch64 as part of pulseaudio

@mariusvniekerk mariusvniekerk merged commit cb051a8 into conda-forge:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants