Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cpython pinning #424

Merged
merged 5 commits into from
Mar 9, 2020
Merged

Cpython pinning #424

merged 5 commits into from
Mar 9, 2020

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Mar 9, 2020

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

How does this relate to PR ( conda-forge/conda-smithy#1244 )?

@isuruf
Copy link
Member Author

isuruf commented Mar 9, 2020

conda-smithy messes up the rerender with the new conda_build_config.yaml from this PR and the python38.yaml migration file from the feedstocks, which has old version. See my two comments at conda-forge/conda-smithy#1243

@isuruf isuruf marked this pull request as ready for review March 9, 2020 21:44
@isuruf isuruf requested a review from a team as a code owner March 9, 2020 21:44
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@beckermr
Copy link
Member

beckermr commented Mar 9, 2020

Man this linter failure is not great. Do we need quotes around the ** in the strings?

@isuruf
Copy link
Member Author

isuruf commented Mar 9, 2020

Hmm, I can't reproduce locally. What's the error message?

@beckermr
Copy link
Member

beckermr commented Mar 9, 2020

@conda-forge-admin relint

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@beckermr
Copy link
Member

beckermr commented Mar 9, 2020

yay!

@isuruf
Copy link
Member Author

isuruf commented Mar 9, 2020

Thanks @beckermr. This is ready for review.

@isuruf isuruf merged commit f88b3cf into conda-forge:master Mar 9, 2020
@isuruf
Copy link
Member Author

isuruf commented Mar 9, 2020

Thanks for the review

@isuruf isuruf deleted the cpython branch March 9, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants