-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "tighten fmt in libmamba" #629
Conversation
This reverts commit f6d2340.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I believe the offending build was marked as broken in conda-forge/admin-requests#902 is that correct? |
Yes, it seems so. Do we need to wait for CDNs to synchronize before merging ? |
The patches were regenerated in this CI job. May take a bit for the CDN to pick that up Though got the sense this change might be less urgent. This based on the fact Axel asked Jaime to review (who is likely done for the day) and presented options for discussion. Also got the sense that other fixes were already in place (this is just relaxing some of them) Please let me know if I'm missing something though. Haven't caught up on all the related threads yet |
The patches from #628 were picked up quickly yesterday, which is what "unbroke" our windows pipelines. Now that a bugfix was identified and backported, we are able to undo that workaround (if we want).
💯 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry for the ping, but I'd love to see this merged to resolve a conflict I'm seeing between |
fmt 10.2 accidentally dropped a symbol that lead to widespread breakage on windows, including all of our windows builds (because it affected mamba itself). After #628 stopped the bleeding, @saraedum went digging and rootcaused+fixed this upstream in fmtlib/fmt#3786, which already made it to conda-forge: conda-forge/fmt-feedstock#42
This means we should be able to drop the pin again, as over time, more and more packages will now build with
fmt 10.2
and thus get afmt >=10.2,<11.0a0
run-export, that would be incompatible with the patched constraints for mamba from #628.An alternative would be to just rebuild mamba once for 10.2, and leave the older builds constrained to 10.1, though I don't really see the need for this if the ABI is fixed.
CC @jaimergp