Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back noarch condition #975

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Add back noarch condition #975

merged 1 commit into from
Feb 19, 2020

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Feb 11, 2020

No description provided.

@jakirkham
Copy link
Member

Oh is this needed again?

@scopatz
Copy link
Member

scopatz commented Feb 12, 2020

LGTM!

@isuruf
Copy link
Member Author

isuruf commented Feb 12, 2020

See @mbargull's explanation at conda/conda#7713 (comment)

wheel which comes lexicographically after is fine. chardet which comes lexicographically before is not

@mbargull mbargull merged commit 767544a into conda-forge:master Feb 19, 2020
@jakirkham
Copy link
Member

Should we then qualify this with the lexicographic point? Asking as we have made some Conda dependencies noarch: python so this may be confusing to people.

@mbargull
Copy link
Member

Oh is this needed again?

conda still doesn't handle noarch: python packages perfectly on Windows.
Ideally it would have some separate conda-python-package-installer (long name to indicate that I didn't think of any actual name) package that would contain the linked console-script .exe* so noarch: python packages won't have that awkward implicit dependency on the base environment's conda.

* (and, IMHO, handle the creation of the entrypoints as well as .pyc compilation etc. -- but that's for another discussion)

@mbargull
Copy link
Member

Should we then qualify this with the lexicographic point?

No, I don't think so. The lexicographical thing is only an implementation detail of conda but not something we should rely on.

@jakirkham
Copy link
Member

So should we revert any noarch: python conversions made to Conda's dependencies?

@isuruf
Copy link
Member Author

isuruf commented Feb 19, 2020

Dependencies like tqdm have been noarch for 3 months, so I don't think we should go back.

@isuruf
Copy link
Member Author

isuruf commented Feb 19, 2020

Even defaults ship tqdm as noarch.

@jakirkham
Copy link
Member

I guess my point is we have now added guidance here that doesn't align with what we are doing. It would be good to either improve the guidance or align with it. No strong feelings on which, but clarity for others would be good 🙂

@mbargull
Copy link
Member

Even defaults ship tqdm as noarch.

Haham, I'm not sure if that was intentional or not..

I can't guarantee that relying on lexicographic order works in every case, though. I'd have to look that up.

@isuruf isuruf deleted the noarch branch March 9, 2020 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants