-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use git tag instead of sdist #8
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
1dbf854
to
d6d35f7
Compare
@danilomendesdias, what do you think of this new approach based on a git tag version of CoolProp that allow its compilation for all conda-forge supported platform and python version. It is as close as possible to the official compilation proposed by CoolProp for Patch to use cmake generator |
@tadeu, can you take a look at this, please? thank you! |
@danilomendesdias @tadeu, is it ok to merge this new structure for the recipe? Once it's merged, I'll propose the update to 6.3.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay, @fcollonval. thank you very much for this contribution.
@danilomendesdias don't worry. I'm glad to contribute to improve this. |
Checklist
Reset the build number to0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Build using git tag to build for all valid Python version supported by conda-forge.