Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git tag instead of sdist #8

Merged
merged 13 commits into from
Oct 6, 2019

Conversation

fcollonval
Copy link
Contributor

@fcollonval fcollonval commented Oct 2, 2019

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Build using git tag to build for all valid Python version supported by conda-forge.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

@fcollonval
Copy link
Contributor Author

@conda-forge-admin, please rerender

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@fcollonval fcollonval force-pushed the patch-2 branch 5 times, most recently from 1dbf854 to d6d35f7 Compare October 3, 2019 14:12
@fcollonval
Copy link
Contributor Author

@danilomendesdias, what do you think of this new approach based on a git tag version of CoolProp that allow its compilation for all conda-forge supported platform and python version. It is as close as possible to the official compilation proposed by CoolProp for pip.

Patch to use cmake generator NMake for windows is a consequence of that issue: conda-forge/conda-forge.github.io#703

@fcollonval fcollonval marked this pull request as ready for review October 3, 2019 14:37
@fcollonval fcollonval changed the title WIP: Use git tag instead of sdist Use git tag instead of sdist Oct 3, 2019
@danilomendesdias danilomendesdias requested a review from tadeu October 3, 2019 15:34
@danilomendesdias
Copy link
Member

@tadeu, can you take a look at this, please? thank you!

@fcollonval
Copy link
Contributor Author

@danilomendesdias @tadeu, is it ok to merge this new structure for the recipe? Once it's merged, I'll propose the update to 6.3.0.

Copy link
Member

@danilomendesdias danilomendesdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay, @fcollonval. thank you very much for this contribution.

@danilomendesdias danilomendesdias merged commit 0b4d238 into conda-forge:master Oct 6, 2019
@fcollonval
Copy link
Contributor Author

@danilomendesdias don't worry. I'm glad to contribute to improve this.

@fcollonval fcollonval deleted the patch-2 branch October 7, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants