Skip to content

Commit

Permalink
Disable failing pselect tests
Browse files Browse the repository at this point in the history
these tests probably never passed on aarch64 but before we did not run
the tests in CI.

See #37.
  • Loading branch information
saraedum committed Dec 2, 2021
1 parent 6dbc67a commit 14d4aa8
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 5 deletions.
44 changes: 40 additions & 4 deletions recipe/issue-159.patch
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
From 33eaadecfdb3221eb7bde43d587d9578d8f7348c Mon Sep 17 00:00:00 2001
From bd405f7a519263b98eb68f971f9bf30d23b25d42 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Julian=20R=C3=BCth?= <[email protected]>
Date: Thu, 2 Dec 2021 01:03:26 -0600
Subject: [PATCH] Remove failing test

see https://github.com/sagemath/cysignals/issues/159
---
src/cysignals/pselect.pyx | 23 -----------------------
1 file changed, 23 deletions(-)
src/cysignals/pselect.pyx | 45 +--------------------------------------
1 file changed, 1 insertion(+), 44 deletions(-)

diff --git a/src/cysignals/pselect.pyx b/src/cysignals/pselect.pyx
index 04fcf31..49a8e36 100644
index 04fcf31..8b5731c 100644
--- a/src/cysignals/pselect.pyx
+++ b/src/cysignals/pselect.pyx
@@ -181,29 +181,6 @@ cdef class PSelecter:
Expand Down Expand Up @@ -42,6 +42,42 @@ index 04fcf31..49a8e36 100644
"""
cdef sigset_t oldset
cdef sigset_t blockset
@@ -246,27 +223,6 @@ cdef class PSelecter:

OUTPUT: ``self``

- TESTS:
-
- Test nesting, where the inner ``with`` statements should have no
- influence, in particular they should not unblock signals which
- were already blocked upon entering::
-
- >>> from cysignals import AlarmInterrupt
- >>> from cysignals.pselect import PSelecter
- >>> import os, signal
- >>> with PSelecter([signal.SIGALRM]) as sel:
- ... os.kill(os.getpid(), signal.SIGALRM)
- ... with PSelecter([signal.SIGFPE]) as sel2:
- ... _ = sel2.sleep(0.1)
- ... with PSelecter([signal.SIGALRM]) as sel3:
- ... _ = sel3.sleep(0.1)
- ... try:
- ... _ = sel.sleep(0.1)
- ... except AlarmInterrupt:
- ... print("Interrupt OK")
- Interrupt OK
-
"""
sigprocmask(SIG_BLOCK, &self.blockset, &self.oldset)
return self
@@ -346,6 +302,7 @@ cdef class PSelecter:
The file ``/dev/null`` should always be available for reading
and writing::

+ >>> import os
>>> from cysignals.pselect import PSelecter
>>> f = open(os.devnull, "r+")
>>> sel = PSelecter()
--
2.34.1

3 changes: 2 additions & 1 deletion recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ source:
- cross.patch # [build_platform != target_platform]
- qemu.patch
- verbose.patch
- issue-159.patch
# See https://github.com/conda-forge/cysignals-feedstock/issues/37
- issue-159.patch # [aarch64]

build:
number: 0
Expand Down

0 comments on commit 14d4aa8

Please sign in to comment.