Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version constraints #46

Merged
merged 5 commits into from
May 9, 2023

Conversation

ReubenJ
Copy link
Contributor

@ReubenJ ReubenJ commented May 9, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Builds on #44, addresses linting issues. Closes #42.

dpath does not currently list 3.11 support, so it might make sense, to include <3.11 in the version constraints, however, I've just opened (dpath-maintainers/dpath-python#187) to add 3.11 to the testing matrix, and mark the package as 3.11 compatible. Waiting on a response for that PR, but running the testing suite locally was successful.

For that reason, I've only included <3.6 for the constraint.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict.
Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices bot and others added 5 commits May 9, 2023 16:18
In response to @conda-forge-webservices linting feedback.
Also bumped build number as required.
@ReubenJ ReubenJ force-pushed the add-version-constraints branch from e4c9a83 to 5299035 Compare May 9, 2023 14:19
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Copy link
Contributor

@asford asford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efiop efiop added the automerge Merge the PR when CI passes label May 9, 2023
Copy link
Member

@efiop efiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot merged commit 4a0f8f8 into conda-forge:main May 9, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@efiop efiop mentioned this pull request May 9, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] aarch64 support
3 participants