Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE Rebuild with gcc 10 for pybind11 compatiblity when building GR OOT modules #112

Closed
wants to merge 3 commits into from

Conversation

ryanvolz
Copy link
Contributor

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ryanvolz ryanvolz added automerge Merge the PR when CI passes and removed automerge Merge the PR when CI passes labels Feb 19, 2022
@ryanvolz ryanvolz changed the title Rebuild with gcc 10 for pybind11 compatiblity when building GR OOT modules DO NOT MERGE Rebuild with gcc 10 for pybind11 compatiblity when building GR OOT modules Feb 19, 2022
@ryanvolz
Copy link
Contributor Author

Actually, to avoid any issues with installing pybind-incompatible gnuradio and OOT packages, updating to GCC 10 should wait until a 3.x.x version update. That's annoying if we have any other package updates or OOT updates in the meantime, but I don't want to be fielding lots of pybind11 incompatibility bug reports.

@ryanvolz ryanvolz marked this pull request as draft March 2, 2022 19:55
@ryanvolz
Copy link
Contributor Author

ryanvolz commented Mar 3, 2022

With the switch from GCC 9 to GCC 10, the issue is that the internal pybind11 identifier changes from

__pybind11_internals_v4_gcc_libstdcpp_cxxabi1013__

to

__pybind11_internals_v4_gcc_libstdcpp_cxxabi1014__

According to pybind/pybind11#2602, we could override this by defining

#define PYBIND11_BUILD_ABI ""

when building gnuradio and any OOTs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants