-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild libprotobuf with a new zlib 1.3 #216
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/libprotobuf-feedstock/actions/runs/8558201563. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong place to tackle this. We need to figure out whether the ABI in zlib changed from 1.2 to 1.3, and then either migrate or patch the repodata. See conda-forge/conda-forge-pinning-feedstock#5443
@h-vetinari What do you think about doing what for example libxml2 does conda-forge/libxml2-feedstock#115? And build it for 2 versions |
It's not sustainable. You would need to rebuild every protobuf-dependent package twice, and soon all of conda-forge. If zlib 1.3 is important to you, please direct your energy to conda-forge/conda-forge-pinning-feedstock#5443. |
zlib needs to be migrated as mentioned by h-vetinari
This PR is obsolete, libprotobuf can be used with zlib 1.3 now. |
This PR was created simply to rebuild libprotobuf with a new zlib 1.3, in order to get rid of such a restriction
what does not allow to install libprotobuf with zlib 1.3
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)