Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild libprotobuf with a new zlib 1.3 #216

Closed
wants to merge 2 commits into from

Conversation

ekomarova
Copy link

@ekomarova ekomarova commented Apr 4, 2024

This PR was created simply to rebuild libprotobuf with a new zlib 1.3, in order to get rid of such a restriction

libprotobuf 5.26.1 h08a7969_0
-----------------------------
file name   : libprotobuf-5.26.1-h08a7969_0.conda
dependencies:
  - libzlib >=1.2.13,<1.3.0a0

what does not allow to install libprotobuf with zlib 1.3

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ekomarova ekomarova changed the title increase build number Rebuild libprotobuf with a new zlib 1.3 Apr 4, 2024
@ekomarova
Copy link
Author

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Apr 4, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/libprotobuf-feedstock/actions/runs/8558201563.

jjerphan
jjerphan previously approved these changes Apr 4, 2024
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the wrong place to tackle this. We need to figure out whether the ABI in zlib changed from 1.2 to 1.3, and then either migrate or patch the repodata. See conda-forge/conda-forge-pinning-feedstock#5443

@ekomarova
Copy link
Author

ekomarova commented Apr 5, 2024

This is the wrong place to tackle this. We need to figure out whether the ABI in zlib changed from 1.2 to 1.3, and then either migrate or patch the repodata. See conda-forge/conda-forge-pinning-feedstock#5443

@h-vetinari What do you think about doing what for example libxml2 does conda-forge/libxml2-feedstock#115? And build it for 2 versions

@h-vetinari
Copy link
Member

What do you think about doing what for example libxml2 does [...] and build it for 2 versions

It's not sustainable. You would need to rebuild every protobuf-dependent package twice, and soon all of conda-forge. If zlib 1.3 is important to you, please direct your energy to conda-forge/conda-forge-pinning-feedstock#5443.

@jjerphan jjerphan dismissed their stale review April 8, 2024 14:51

zlib needs to be migrated as mentioned by h-vetinari

@h-vetinari
Copy link
Member

This PR is obsolete, libprotobuf can be used with zlib 1.3 now.

@h-vetinari h-vetinari closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants