Rls 1.1.0rc0 #84

TomAugspurger · 2020-07-17T19:55:25Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

RLS 1.0.0rc0

…into dev

…da-forge-pinning 2020.07.17.17.28.25

conda-forge-linter · 2020-07-17T19:55:32Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter · 2020-07-17T19:56:53Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter · 2020-07-17T20:30:24Z

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

requirements: host: numpy>=1.15.4 must contain a space between the name and the pin, i.e. numpy >=1.15.4

conda-forge-linter · 2020-07-17T20:31:29Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

TomAugspurger · 2020-07-17T20:58:54Z

Hmm, we seem to be running into pandas-dev/pandas#33315 / pandas-dev/pandas#33314. I'm not sure what's best here, but I'm leaning towards patching the setup.py to ignore errors on OSX?

  creating build/temp.macosx-10.9-x86_64-3.7
  creating build/temp.macosx-10.9-x86_64-3.7/pandas
  creating build/temp.macosx-10.9-x86_64-3.7/pandas/_libs
  x86_64-apple-darwin13.4.0-clang -fno-strict-aliasing -Wsign-compare -Wunreachable-code -DNDEBUG -fwrapv -O3 -Wall -Wstrict-prototypes -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O3 -pipe -fdebug-prefix-map=${SRC_DIR}=/usr/local/src/conda/${PKG_NAME}-${PKG_VERSION} -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/pandas_1595017990358/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl=/usr/local/src/conda-prefix -flto -Wl,-export_dynamic -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O3 -march=core2 -mtune=haswell -mssse3 -ftree-vectorize -fPIC -fPIE -fstack-protector-strong -O2 -pipe -isystem /Users/runner/miniforge3/conda-bld/pandas_1595017990358/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/pandas_1595017990358/work=/usr/local/src/conda/pandas-1.1.0rc0 -fdebug-prefix-map=/Users/runner/miniforge3/conda-bld/pandas_1595017990358/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl=/usr/local/src/conda-prefix -D_FORTIFY_SOURCE=2 -mmacosx-version-min=10.9 -isystem /Users/runner/miniforge3/conda-bld/pandas_1595017990358/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include -DNPY_NO_DEPRECATED_API=0 -I./pandas/_libs -Ipandas/_libs/src/klib -I/Users/runner/miniforge3/conda-bld/pandas_1595017990358/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/lib/python3.7/site-packages/numpy/core/include -I/Users/runner/miniforge3/conda-bld/pandas_1595017990358/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/include/python3.7m -c pandas/_libs/algos.c -o build/temp.macosx-10.9-x86_64-3.7/pandas/_libs/algos.o -Werror
  clang-10: error: -Wl,-export_dynamic: 'linker' input unused [-Werror,-Wunused-command-line-argument]
  error: command 'x86_64-apple-darwin13.4.0-clang' failed with exit status 1
  ----------------------------------------
  ERROR: Failed building wheel for pandas
Failed to build pandas
ERROR: Could not build wheels for pandas which use PEP 517 and cannot be installed directly
Traceback (most recent call last):
  File "/Users/runner/miniforge3/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 474, in main
    execute(sys.argv[1:])
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/cli/main_build.py", line 465, in execute
    verify=args.verify, variants=args.variants)
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/api.py", line 209, in build
    notest=notest, need_source_download=need_source_download, variants=variants)
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/build.py", line 2864, in build_tree
    notest=notest,
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/build.py", line 1995, in build
    cwd=src_dir, stats=build_stats)
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/utils.py", line 404, in check_call_env
    return _func_defaulting_env_to_os_environ('call', *popenargs, **kwargs)
  File "/Users/runner/miniforge3/lib/python3.7/site-packages/conda_build/utils.py", line 384, in _func_defaulting_env_to_os_environ
    raise subprocess.CalledProcessError(proc.returncode, _args)
subprocess.CalledProcessError: Command '['/bin/bash', '-o', 'errexit', '/Users/runner/miniforge3/conda-bld/pandas_1595017990358/work/conda_build.sh']' returned non-zero exit status 1.

xhochy · 2020-07-18T05:41:33Z

recipe/meta.yaml

-    - cython >=0.28.2
-    - numpy
+    - cython >=0.29.16
+    - numpy >=1.15.4


Pin exact here to get the oldest possible numpy version.

TomAugspurger · 2020-07-18T15:07:46Z

@conda-forge-admin, please rerender

…da-forge-pinning 2020.07.18.02.18.36

…s-feedstock into RLS-1.1.0rc0

TomAugspurger · 2020-07-18T15:39:16Z

recipe/meta.yaml

-    - cython >=0.28.2
-    - numpy
+    - cython >=0.29.16
+    - numpy ==1.15.4  # [py != 38]


@xhochy can you check my work here? NumPy 1.17.3 is the first to support python 3.8.

Seems that this will need some work for other platforms:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-aarch64: {'numpy==1.15.4'}

cc @odidev if you have any suggestions.

Actually we build Python 3.8 wheels with numpy 1.16 on conda-forge. #85

Also made a PR to ease numpy pinnings for maintainers: conda-forge/conda-forge-pinning-feedstock#701

Seems that this will need some work for other platforms:

conda_build.exceptions.DependencyNeedsBuildingError: Unsatisfiable dependencies for platform linux-aarch64: {'numpy==1.15.4'}

cc @odidev if you have any suggestions.

@TomAugspurger,
Can we use numpy>=1.16.3?
Note: AArch64 and PowerPC architectures are supported from numpy version >= 1.16.3(reference 1.16.3).

Uwe fixed it in #85 if you want to check that.

TomAugspurger · 2020-07-18T15:39:32Z

@conda-forge-admin, please rerender

github-actions · 2020-07-18T15:40:51Z

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

TomAugspurger · 2020-07-19T15:47:11Z

@conda-forge-admin, please rerender

TomAugspurger · 2020-07-19T15:47:41Z

One notable change, the label will now be pandas_rc rather than just rc to comply with https://github.com/conda-forge/cfep/blob/master/cfep-05.md.

…da-forge-pinning 2020.07.18.20.56.00

TomAugspurger · 2020-07-19T17:21:21Z

aarch64 is failing because of #84 (comment).

I'm not sure why powerpc is timing out, but I'm not going to hold up the rest for it.

WillAyd · 2020-11-17T02:17:51Z

Just a guess based off of error message and this SO post:

https://stackoverflow.com/questions/12652641/cflags-wl-export-dynamic-vs-linker-flags-export-dynamic

But maybe the argument should be --export-dynamic on macOS? (note two hyphens)

WillAyd · 2020-11-17T02:30:55Z

Alternately maybe we can get rid of that option altogether? Not super familiar with this toolchain so not clear where that is coming from, but the man page for ld reads as follows:

     -export_dynamic
                 Preserves all global symbols in main executables during LTO.  Without this option, Link Time Optimiza-
                 tion is allowed to inline and remove global functions. This option is used when a main executable may
                 load a plug-in which requires certain symbols from the main executable.

I don't think pandas needs that at all? And it may in fact be beneficial to remove?

TomAugspurger and others added 4 commits January 9, 2020 21:40

Merge pull request conda-forge#73 from TomAugspurger/RLS-1.0.0rc0

44c07b8

RLS 1.0.0rc0

Merge branch 'dev' of https://github.com/conda-forge/pandas-feedstock …

6f5f57d

…into dev

RLS 1.1.0rc0

d492908

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.7.4, and con…

382de47

…da-forge-pinning 2020.07.17.17.28.25

TomAugspurger requested review from jorisvandenbossche, jreback, msarahan, ocefpaf and WillAyd as code owners July 17, 2020 19:55

please the linter

b0d5384

TomAugspurger added 2 commits July 17, 2020 15:29

specify numpy

9d93c70

bump versions

c5e6a39

fixup

32807bc

patch

4bc62ef

TomAugspurger mentioned this pull request Jul 17, 2020

Remove -Werror from setup.py pandas-dev/pandas#33315

Closed

run builds

1003df6

xhochy reviewed Jul 18, 2020

View reviewed changes

pin exact

698e956

conda-forge-linter and others added 3 commits July 18, 2020 15:09

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.7.4, and con…

d498268

…da-forge-pinning 2020.07.18.02.18.36

pins

78c63d4

Merge branch 'RLS-1.1.0rc0' of https://github.com/TomAugspurger/panda…

6cf6a05

…s-feedstock into RLS-1.1.0rc0

TomAugspurger commented Jul 18, 2020

View reviewed changes

follow CFEP-05 guidelines

f258734

MNT: Re-rendered with conda-build 3.19.2, conda-smithy 3.7.4, and con…

353e7e4

…da-forge-pinning 2020.07.18.20.56.00

TomAugspurger merged commit 7fb8b0a into conda-forge:dev Jul 19, 2020

TomAugspurger deleted the RLS-1.1.0rc0 branch July 19, 2020 17:21

jorisvandenbossche mentioned this pull request Dec 8, 2020

RLS: 1.2 pandas-dev/pandas#37784

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rls 1.1.0rc0 #84

Rls 1.1.0rc0 #84

TomAugspurger commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

TomAugspurger commented Jul 17, 2020 •

edited

Loading

xhochy Jul 18, 2020

TomAugspurger commented Jul 18, 2020

TomAugspurger Jul 18, 2020

TomAugspurger Jul 19, 2020

xhochy Jul 19, 2020

odidev Jul 20, 2020

TomAugspurger Jul 20, 2020

odidev Jul 20, 2020

TomAugspurger commented Jul 18, 2020

github-actions bot commented Jul 18, 2020

TomAugspurger commented Jul 19, 2020

TomAugspurger commented Jul 19, 2020

TomAugspurger commented Jul 19, 2020

WillAyd commented Nov 17, 2020

WillAyd commented Nov 17, 2020

Rls 1.1.0rc0 #84

Rls 1.1.0rc0 #84

Conversation

TomAugspurger commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

conda-forge-linter commented Jul 17, 2020

TomAugspurger commented Jul 17, 2020 • edited Loading

xhochy Jul 18, 2020

Choose a reason for hiding this comment

TomAugspurger commented Jul 18, 2020

TomAugspurger Jul 18, 2020

Choose a reason for hiding this comment

TomAugspurger Jul 19, 2020

Choose a reason for hiding this comment

xhochy Jul 19, 2020

Choose a reason for hiding this comment

odidev Jul 20, 2020

Choose a reason for hiding this comment

TomAugspurger Jul 20, 2020

Choose a reason for hiding this comment

odidev Jul 20, 2020

Choose a reason for hiding this comment

TomAugspurger commented Jul 18, 2020

github-actions bot commented Jul 18, 2020

TomAugspurger commented Jul 19, 2020

TomAugspurger commented Jul 19, 2020

TomAugspurger commented Jul 19, 2020

WillAyd commented Nov 17, 2020

WillAyd commented Nov 17, 2020

TomAugspurger commented Jul 17, 2020 •

edited

Loading