Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test image flaged by AV software #114

Merged

Conversation

johnbradley
Copy link
Contributor

@johnbradley johnbradley commented Mar 14, 2022

Remove crash-81154a65438ba5aaeca73fd502fa4850fbde60f8.tif test image.
This is a valid test file but the antivirus software flagged it as "potential malware". The associated test should just skip
since the input file will no longer exist. The test image is still accessible from: https://github.com/python-pillow/pillow-depends/tree/main/test_images

Increment the build number.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Related to Issue #113

Remove crash-81154a65438ba5aaeca73fd502fa4850fbde60f8.tif test image.
This is a valid test file but the antivirus software flagged it
as "potential malware". The associated test should just skip
since the input file will no longer exist.
The test image is still accessible from:
https://github.com/python-pillow/pillow-depends/tree/main/test_images

Increment the build number.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@johnbradley
Copy link
Contributor Author

The tests are failing on the missing crash-81154a65438ba5aaeca73fd502fa4850fbde60f8.tif test file: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=474402&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=4063

I will look into this error in a few days when time permits.

@h-vetinari
Copy link
Member

It's completely expected that the tests that require the image you removed will fail. Just add them to the tests_to_skip variable that already exists in the recipe and you should be fine.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Apr 13, 2022
@h-vetinari
Copy link
Member

Thanks for this! :)

@github-actions github-actions bot merged commit 5f83011 into conda-forge:main Apr 13, 2022
@github-actions
Copy link
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants