Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual aarch migration #57

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I've started rerendering the recipe as instructed in #56.

If I find any needed changes to the recipe, I'll push them to this PR shortly. Thank you for waiting!

Here's a checklist to do before merging.

  • Bump the build number if needed.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk hmaarrfk changed the title MNT: rerender Manual aarch migration Apr 21, 2024
@hmaarrfk
Copy link

@conda-forge-admin please rerender

- pkg-config
- jupyter
- setuptools_scm >=8
- jupyter_core

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that this change, jupyter -> jupyter_core didn't accidentally delete a feature of your package.

I see that jupyter is used in some tests.
https://github.com/SHTOOLS/SHTOOLS/blob/77ecaabbe90aee89ecc252317c8c6b4258e59bad/examples/notebooks/meson.build#L4

We are honestly pretty "light on tests" at conda-forge to favor ease of building.

Maybe you can just remove jupyter from a build time dependency altogether?

@hmaarrfk
Copy link

@conda-forge-admin please rerender

@MarkWieczorek
Copy link
Contributor

MarkWieczorek commented Apr 21, 2024

Thanks for looking into this! For Jupyter: we actually don't run the tests that require jupyter. However, the meson-build system that we are using checks anyways to make sure that its installed and fails if it isn't. jupyter-core is fine, in fact I think that is what we use in our ci-tests.

@hmaarrfk
Copy link

I think you have some issues with your cross compilation. I'm quite bad at meson and just use the github search to find something to copy.

The fact the arch and ppc64le packages were failing on azure + cross compilation indicates that maybe your mac osx package is broken.

I'm not sure why windows is failing now that I moved pkg-config. You should investigate.

While travis is "fast" it is quite "unreliable" and will randomly fail at jobs. Given the build is fast, we can try emulation + azure. This will be my last "push" to this PR.

@hmaarrfk
Copy link

@conda-forge-admin please rerender

@hmaarrfk
Copy link

However, the meson-build system that we are using checks anyways to make sure that its installed and fails if it isn't.

That is unfortunate. Maybe this is something to consider for future work.

@MarkWieczorek
Copy link
Contributor

@jan-janssen Would you mind taking a quick look at windows builds, since you were the one to get these working. Perhaps the solutions is make pkg-config a host dependency?

@jan-janssen
Copy link
Member

Perhaps the solutions is make pkg-config a host dependency?

@MarkWieczorek This week is rather busy for me. If you have a concrete idea, I would suggest just testing it on a separate branch. My Windows expertise is also limited all I can do is trail and error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants