Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qiskit-aer v0.12.1 #9

Merged
merged 2 commits into from
Jul 12, 2023
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • scikit-build

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5251031867, please use this URL for debugging.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@wshanks
Copy link
Contributor

wshanks commented Jun 13, 2023

I am tempted to leave this unmerged because it is known to break things (Qiskit/qiskit#10270) and so I expect another release will be made soon. On the other hand, the release notes mention several bug fixes, so if someone felt strongly about those we could merge this and let users pin to a lower version as needed.

Separately, we need to fix the build. From the log, it looks like scikit-build is building with make rather than ninja. This might be related to something that changed in scikit-build 0.17 which was released since the last time the feedstock was built.

@wshanks
Copy link
Contributor

wshanks commented Jun 13, 2023

@henryiii Do you have any idea why this run failed using scikit-build 0.17.6, but then pinning to 0.16.7 here passed? The recipe is using Ninja with SKBUILD_CONFIGURE_OPTIONS="-GNinja" in script_env and the failure shows cmake trying to build with make, like it did not pick up the -GNinja option. Nothing jumps out to me in the scikit-build release notes, with scikit-build/scikit-build#975 being the closest thing to relevant.

@henryiii
Copy link
Contributor

henryiii commented Jun 13, 2023

I'd first recommend setting CMAKE_GENERATOR to Ninja instead. Conda-build sets CMAKE_GENERATOR to Makefiles, which is really frustrating and incorrect when make is not installed but ninja is, but I don't think I can get them to unset that.

I think we are likely not inspecting the args for -G, so it's getting CMAKE_MAKE_PROGRAM (or whatever the variable is that sets the location of the generator) incorrectly passed.

@wshanks
Copy link
Contributor

wshanks commented Jun 13, 2023

Thanks @henryiii, that change did not help, but it did point me to understanding why things broke with scikit-build 0.17. With scikit-build 0.16, it was actually not working as intended either. Instead, scikit-build was pulling in make and using it even though I had tried to configure it up to use ninja. This change to the scikit-build feedstock for 0.17 removed its make dependency, leading to the build here now failing trying to find make. Is there anything else I could try to get cmake to use ninja? If not, I can add make as a build depdency and remove ninja.

@henryiii
Copy link
Contributor

You might need to set this inside the build process, rather than in the script_env. Conda-build is quite ruthless in overriding this when you try to set it.

recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
@wshanks
Copy link
Contributor

wshanks commented Jun 13, 2023

Thanks @henryiii! That seems to be working.

@regro-cf-autotick-bot regro-cf-autotick-bot mentioned this pull request Jul 12, 2023
3 tasks
@leofang
Copy link
Member

leofang commented Jul 12, 2023

@wshanks shall we merge this PR first?

@wshanks wshanks merged commit 32a7e00 into conda-forge:main Jul 12, 2023
@wshanks
Copy link
Contributor

wshanks commented Jul 12, 2023

Sure, that seems reasonable since we can shortly make the next version available.

@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.12.1_h762677 branch July 12, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants