Migration to conda build 3 - Qt4 #94

marcelotrevisani · 2019-02-21T15:04:15Z

Checklist

Used a fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-linter · 2019-02-21T15:04:22Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

marcelotrevisani · 2019-02-21T15:06:18Z

Related to #83

marcelotrevisani · 2019-02-21T15:07:21Z

@conda-forge-admin , please rerender

…nda-forge-pinning 2019.02.21

ccordoba12

Left a couple of comments that I think will help to make the builds pass on Linux.

recipe/meta.yaml

Removed dbus and libxcb

marcelotrevisani · 2019-02-22T10:12:20Z

It seems that it needs dbus 0.93

cc: @jakirkham

ccordoba12 · 2019-02-22T10:16:03Z

@marcelotrevisani, I think you can instruct Qt to not build the dbus bindings. They are not that important in Qt4.

denivyruck · 2019-03-06T14:48:53Z

recipe/build.sh

@@ -5,8 +5,8 @@
 chmod +x configure

 if [ $(uname) == Linux ]; then
-    compiler_mkspec=qtbase/mkspecs/common/g++-base.conf
-    flag_mkspec=qtbase/mkspecs/linux-g++/qmake.conf
+    compiler_mkspec=mkspecs/common/g++-base.conf


Change also on else

I will wait linux to finish

denivyruck · 2019-03-07T11:38:34Z

recipe/meta.yaml

+    - {{ cdt('libxxf86vm') }}  # [linux]
+    - {{ cdt('libx11-devel') }}  # [linux]
+    - {{ cdt('libxext-devel') }}  # [linux]
+    - perl


Please add expat as well to solve linux XML issues

denivyruck · 2019-03-07T11:39:13Z

recipe/meta.yaml

+    - xorg-libx11      # [linux]
+    - xorg-libxext     # [linux]
+    - xorg-libxrender  # [linux]
+    - xorg-libxt       # [linux]

 test:
  files:


Add {{ compiler('cxx') }} otherwise the tests will fail

denivyruck · 2019-03-07T11:50:03Z

On windows it's compiling with -system-libtiff but still it's not found: fatal error LNK1181: cannot open input file 'libtiff.lib'. Let's try to compile it with -qt-libtiff?

denivyruck · 2019-03-07T12:33:11Z

recipe/build.sh

+    export CPPFLAGS="$CPPFLAGS -DGLX_GLXEXT_PROTOTYPES"
+else
+    compiler_mkspec=mkspecs/common/clang.conf
+    flag_mkspec=mkspecs/macx-clang/qmake.conf


On Qt4 archive we don't have this configuration, we only have:

macx-icc

macx-llvm

macx-pbbuilder

macx-xcode

macx-xlc

We do have darwin-g++ tho.

Sorry I just checked we also have 'macx-g++', 'g++40' and 'g++42'. My eyes are failing me

Not a problem, anyway I'm using macx-llvm

@marcelotrevisani, Qt 4 probably doesn't compile with the latest Clang, so you should use g++42 (at least that's what we used in Anaconda).

Ok! I will change it! I will just wait the CI linux to finish
Thanks!

marcelotrevisani · 2019-03-07T12:43:52Z

On windows it's compiling with -system-libtiff but still it's not found: fatal error LNK1181: cannot open input file 'libtiff.lib'. Let's try to compile it with -qt-libtiff?

I really don't like it, I would like to use that just if there is no other option. The reason is: in conda in general we try to avoid internal dependencies of each package, in this case qt rely on libtiff which would be better to use from a package or from our cdt packages, because if we use qt-libtiff it will use a libtiff which is shipped along with qt4, which we want to avoid.

denivyruck · 2019-03-07T12:47:28Z

@marcelotrevisani ooooh I see. Do we have a cdt package for that then? I see it's already included as a dependency (but not cdt)

marcelotrevisani · 2019-03-07T12:51:02Z

@marcelotrevisani ooooh I see. Do we have a cdt package for that then? I see it's already included as a dependency

Yes, we have to investigate why is not finding this lib, because it is already included... which is odd

denivyruck · 2019-03-11T14:32:45Z

@ccordoba12 we're having some weird issues on osx when testing. Did you ever see this before? Seems like he's getting the wrong SDK somehow.

ld: warning: ignoring file /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib/libSystem.tbd, file was built for unsupported file format ( 0x2D 0x2D 0x2D 0x20 0x21 0x74 0x61 0x70 0x69 0x2D 0x74 0x62 0x64 0x2D 0x76 0x33 ) which is not the architecture being linked (x86_64): /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/lib/libSystem.tbd
Undefined symbols for architecture x86_64:
  "__Unwind_Resume", referenced from:
      _main in main.o
      QDebug::operator<<(char const*) in main.o
      QDebug::~QDebug() in main.o
  "___stack_chk_fail", referenced from:
      _main in main.o
      QDebug::operator<<(char const*) in main.o
      QDebug::~QDebug() in main.o
  "___stack_chk_guard", referenced from:
      _main in main.o
      QDebug::operator<<(char const*) in main.o
      QDebug::~QDebug() in main.o
ld: symbol(s) not found for architecture x86_64

ccordoba12 · 2019-03-11T14:50:57Z

That's very similar to

https://travis-ci.org/conda-forge/pyqt-feedstock/jobs/488744479#L602

(from conda-forge/pyqt-feedstock#45) but I don't understand its cause. As far as I know, it's an XCode issue (i.e. you probably need to use an older XCode to build Qt4).

denivyruck · 2019-03-11T14:56:51Z

That's very similar to

https://travis-ci.org/conda-forge/pyqt-feedstock/jobs/488744479#L602

(from conda-forge/pyqt-feedstock#45) but I don't understand its cause. As far as I know, it's an XCode issue (i.e. you probably need to use an older XCode to build Qt4).

Nice! I'll try to investigate that, thanks :)

This reverts commit 784da3e.

marcelotrevisani · 2019-03-12T11:43:05Z

cc: @ocefpaf
Do you have some hint here? Just osx is failing

I skipped the other platforms because they are already passing and qt takes too much time to compile, just trying to save some time in our CI

marcelotrevisani · 2019-03-12T11:44:32Z

For some reason is trying to compile for i386 even when we specified x86_64

denivyruck · 2019-03-12T18:25:52Z

For some reason is trying to compile for i386 even when we specified x86_64

If you remove the arch flag it will turn back to 64 lol

…into qt4

marcelotrevisani · 2019-03-29T15:40:28Z

@conda-forge-admin , please rerender

…da-forge-pinning 2019.03.17

marcelotrevisani · 2019-03-29T17:51:17Z

@ocefpaf , please review and merge it if you agree
:)

ocefpaf · 2019-03-29T17:54:32Z

@ocefpaf , please review and merge it if you agree
:)

88 commits and 37 changed files... I guess that only the CIs will be "reviewing" this PR ;-p

ocefpaf · 2019-03-29T17:56:28Z

recipe/meta.yaml

@@ -102,3 +137,4 @@ extra:
    - mingwandroid
    - gillins
    - msarahan
+    - marcelotrevisani


ocefpaf · 2019-03-29T17:56:59Z

recipe/meta.yaml

  files:
    - test
  commands:
+
    - conda inspect linkages -p $PREFIX qt  # [not win]
    - conda inspect objects -p $PREFIX qt  # [osx]


We no longer need these lines but let's get this merged as soon as it passes. We can remove these with a [skip ci] PR later.

ocefpaf · 2019-03-29T17:58:19Z

recipe/meta.yaml

-    - vc9  # [win and py27]
-    - vc10  # [win and py34]
-    - vc14  # [win and py>=35]
+  number: 1000


This can be 9 instead of 1000 not that the migration is done the 1000 has no meaning.
(Also, if it was during the migration, it should've been 1009.)

ocefpaf · 2019-03-29T17:58:50Z

recipe/meta.yaml

-    - vc10  # [win and py34]
-    - vc14  # [win and py>=35]
+  number: 1000
+  # skipping linux for now, because it is already being packaged on Linux


These comments are staled. Can you removed them?

ocefpaf

Minor comments that can be addressed now or later. It is up to you if you are in a hurry to get this merged.

Migration to conda build 3

e228ec4

Bump build number

7dcc17b

conda-forge-admin and others added 3 commits February 21, 2019 15:07

MNT: Re-rendered with conda-build 3.17.8, conda-smithy 3.2.13, and co…

dcda1e8

…nda-forge-pinning 2019.02.21

Update url

d93f145

Selectors for the cdt packages

d6b9295

ccordoba12 reviewed Feb 21, 2019

View reviewed changes

recipe/meta.yaml Outdated Show resolved Hide resolved

recipe/meta.yaml Outdated Show resolved Hide resolved

Update requirements

0b3aa73

Removed dbus and libxcb

marcelotrevisani added 2 commits February 22, 2019 10:20

Removed dbus support

ee5dbea

Add flag no-dbus

4935594

marcelotrevisani mentioned this pull request Mar 6, 2019

Pin pyqt 4 conda-forge/guiqwt-feedstock#2

Closed

5 tasks

marcelotrevisani added 5 commits March 6, 2019 13:00

add libx11

f3a33d0

WIP - TEST

8013208

add libxext

af1a27b

Update build

9ce018d

Add mkspec

f94db3d

denivyruck reviewed Mar 6, 2019

View reviewed changes

marcelotrevisani added 2 commits March 6, 2019 16:02

Using c++98

a5ed826

add mesa libgl

e7fabda

denivyruck reviewed Mar 7, 2019

View reviewed changes

denivyruck added 5 commits March 11, 2019 16:00

Remove redundant patch

784da3e

Remove arch patch

1c27d0a

Re-add deployment patch

2cc5765

Revert "Remove redundant patch"

651ebc0

This reverts commit 784da3e.

Add architecture flag

840a0df

Testing macx-clang

f0648a8

denivyruck added 3 commits March 12, 2019 19:30

Remove arch flag

b2e590f

Merge branch 'qt4' of https://github.com/marcelotrevisani/qt-feedstock …

0787099

…into qt4

Return to clang-libc++

e9e7df0

ceholden mentioned this pull request Mar 27, 2019

update package to 2.18.20 conda-forge/qgis-feedstock#38

Closed

5 tasks

Skip osx

31e8216

MNT: Re-rendered with conda-build 3.17.8, conda-smithy 3.3.2, and con…

7dd84ec

…da-forge-pinning 2019.03.17

ocefpaf reviewed Mar 29, 2019

View reviewed changes

recipe/meta.yaml

@@ -102,3 +137,4 @@ extra:

- mingwandroid

- gillins

- msarahan

- marcelotrevisani

Copy link

Member

ocefpaf Mar 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ocefpaf reviewed Mar 29, 2019

View reviewed changes

ocefpaf approved these changes Mar 29, 2019

View reviewed changes

Improvements

9bdf11f

ocefpaf merged commit d6642bc into conda-forge:qt4 Mar 29, 2019

This was referenced Apr 23, 2019

Rebuilding Qt 4 with the new compilers #83

Closed

Rebuild for Python 3.7, GCC 7, R 3.5.1, openBLAS 0.3.2 conda-forge/pyside-feedstock#38

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration to conda build 3 - Qt4 #94

Migration to conda build 3 - Qt4 #94

marcelotrevisani commented Feb 21, 2019

conda-forge-linter commented Feb 21, 2019

marcelotrevisani commented Feb 21, 2019

marcelotrevisani commented Feb 21, 2019

ccordoba12 left a comment

marcelotrevisani commented Feb 22, 2019 •

edited

Loading

ccordoba12 commented Feb 22, 2019

denivyruck Mar 6, 2019

marcelotrevisani Mar 6, 2019

denivyruck Mar 7, 2019

denivyruck Mar 7, 2019

denivyruck commented Mar 7, 2019 •

edited

Loading

denivyruck Mar 7, 2019

denivyruck Mar 7, 2019

denivyruck Mar 7, 2019

marcelotrevisani Mar 7, 2019

ccordoba12 Mar 7, 2019

marcelotrevisani Mar 7, 2019

marcelotrevisani commented Mar 7, 2019

denivyruck commented Mar 7, 2019 •

edited

Loading

marcelotrevisani commented Mar 7, 2019

denivyruck commented Mar 11, 2019 •

edited

Loading

ccordoba12 commented Mar 11, 2019

denivyruck commented Mar 11, 2019

marcelotrevisani commented Mar 12, 2019 •

edited

Loading

marcelotrevisani commented Mar 12, 2019

denivyruck commented Mar 12, 2019

marcelotrevisani commented Mar 29, 2019

marcelotrevisani commented Mar 29, 2019

ocefpaf commented Mar 29, 2019

ocefpaf Mar 29, 2019

ocefpaf Mar 29, 2019

ocefpaf Mar 29, 2019

ocefpaf Mar 29, 2019

ocefpaf left a comment

Migration to conda build 3 - Qt4 #94

Migration to conda build 3 - Qt4 #94

Conversation

marcelotrevisani commented Feb 21, 2019

conda-forge-linter commented Feb 21, 2019

marcelotrevisani commented Feb 21, 2019

marcelotrevisani commented Feb 21, 2019

ccordoba12 left a comment

Choose a reason for hiding this comment

marcelotrevisani commented Feb 22, 2019 • edited Loading

ccordoba12 commented Feb 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

denivyruck commented Mar 7, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

marcelotrevisani commented Mar 7, 2019

denivyruck commented Mar 7, 2019 • edited Loading

marcelotrevisani commented Mar 7, 2019

denivyruck commented Mar 11, 2019 • edited Loading

ccordoba12 commented Mar 11, 2019

denivyruck commented Mar 11, 2019

marcelotrevisani commented Mar 12, 2019 • edited Loading

marcelotrevisani commented Mar 12, 2019

denivyruck commented Mar 12, 2019

marcelotrevisani commented Mar 29, 2019

marcelotrevisani commented Mar 29, 2019

ocefpaf commented Mar 29, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ocefpaf left a comment

Choose a reason for hiding this comment

marcelotrevisani commented Feb 22, 2019 •

edited

Loading

denivyruck commented Mar 7, 2019 •

edited

Loading

denivyruck commented Mar 7, 2019 •

edited

Loading

denivyruck commented Mar 11, 2019 •

edited

Loading

marcelotrevisani commented Mar 12, 2019 •

edited

Loading