Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rdkit location on osx-arm64 #121

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Fix rdkit location on osx-arm64 #121

merged 4 commits into from
Jan 17, 2023

Conversation

bkpoon
Copy link
Member

@bkpoon bkpoon commented Jan 14, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Fixes #120

This PR removes the PYTHON_INSTDIR cmake argument which was set to $SP_DIR. During cross-compiling, $SP_DIR was always set to 3.10 instead of the specific Python version for the build.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@bkpoon
Copy link
Member Author

bkpoon commented Jan 14, 2023

@conda-forge-admin, please rerender

@github-actions
Copy link
Contributor

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/rdkit-feedstock/actions/runs/3918294664.

@mcs07
Copy link
Contributor

mcs07 commented Jan 17, 2023

Awesome! This feels like a bug in conda-build? Although good to see that SP_DIR isn't actually needed.

@mcs07 mcs07 merged commit 873654b into conda-forge:main Jan 17, 2023
@bkpoon bkpoon deleted the update branch January 19, 2023 18:34
@bkpoon
Copy link
Member Author

bkpoon commented Jan 19, 2023

Thanks! I think the issue has something with the cross-compiling process where some environment variables are not updated. It's something I'll try to look into once I find some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rdkit says it's installed but it is not available
2 participants