Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Windows activation to use VS2019 #28

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

pkgw
Copy link
Contributor

@pkgw pkgw commented Oct 4, 2022

Inspired by conda-forge/cryptography-feedstock#104 and my reading of conda-forge/conda-forge.github.io#1732, I think the Rust activation packages on Windows need updating to stay in sync with the VS2019 bump.

xref conda-forge/conda-forge-pinning-feedstock#3167
xref conda-forge/conda-forge.github.io#1810

CC @h-vetinari

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@pkgw pkgw requested review from isuruf and xhochy as code owners October 4, 2022 20:43
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf isuruf added the automerge Merge the PR when CI passes label Oct 4, 2022
@github-actions github-actions bot merged commit 17f0387 into conda-forge:main Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@pkgw pkgw deleted the vs2019 branch October 4, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants