rust v1.50.0 #75

regro-cf-autotick-bot · 2021-02-11T16:24:10Z

It is very likely that the current package version for this feedstock is out of date.
Notes for merging this PR:

Feel free to push to the bot's branch to update this PR if needed.
The bot will almost always only open one PR per version.
Checklist before merging this PR:

Dependencies have been updated if changed: see upstream
Tests have passed
Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

_{This PR was created by the regro-cf-autotick-bot.

The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable.

Finally, feel free to drop us a line if there are any issues!

This PR was generated by https://github.com/regro/autotick-bot/actions/runs/558337160, please use this URL for debugging}

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name	Upstream Version	Current Version
rust	1.50.0

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis of the source code shows a discrepancy between the library's imports and the package's stated requirements in the meta.yaml.

Packages found by inspection but not in the meta.yaml:

rust

…da-forge-pinning 2021.02.11.03.11.06

conda-forge-linter · 2021-02-11T16:24:16Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pkgw · 2021-02-11T21:27:47Z

Drone build seems to have timed out. Unclear to me what happened with Travis — no obvious error message that I'm seeing in the log.

Also, AFAIK, the issue with introduced in 1.49, where Rust has bumped its minimum support macOS version (rust-lang/rust#80804), is still present.

pkgw · 2021-02-17T21:55:00Z

@conda-forge-admin please restart ci

Let's see if any of these issues have decided to magically fix themselves ...

pkgw · 2021-02-18T13:39:38Z

Cool, Travis did fix itself! @conda-forge/core do we have a way to increase the timeouts for selected builds on Drone?

ocefpaf · 2021-02-18T18:32:56Z

Cool, Travis did fix itself! @conda-forge/core do we have a way to increase the timeouts for selected builds on Drone?

This has been plaguing us for a while. Looks like sometimes we get drone instances that are more roust than others. I'm not sure what we can do at the moment besides restart it :-(

mbargull · 2021-02-19T08:31:04Z

Yes, it would be nice to be able to up the timeout for arm64 builds on some of our feedstocks.
For this one it shouldn't be needed though. I pushed a small change that should get us under the time limit.
(And ultimately, it would also make sense to improve the install.sh upstream -- that one is just a bash script which is only so slow because it does a lot (via subprocesses) for each of the 18-19K files that get copied. If fixed, the script should easily be able to finish in a matter of seconds.)

recipe/install-rust.sh

mbargull · 2021-02-19T10:45:28Z

I pushed a small change that should get us under the time limit.

Wow, that wasn't enough, apparently o_O.
I'll write a patch for upstream and add it here then.

…ins.patch

pkgw · 2021-02-19T13:39:49Z

Wow, nice work! I was wondering why it was taking so long to just repackage some downloaded files but didn't seriously consider reworking the installation process ...

isuruf · 2021-02-19T15:54:11Z

Before merging this, we need to pin rust to 1.48 on osx-64.

stain · 2021-02-21T18:38:09Z

@isuruf I am not sure how to do such pinning within a recipe (I know you can do such in dependencies of this package)

In https://github.com/conda-forge/admin-requests/pull/212/files this was done by labeling 1.49.0 as broken on platform osx-64 (osx-arm64 is obviously at modern enough macOS).

Indeed installing rust today on macOS 10.13 from conda-forge "correctly" installs 1.48.0 (we can't select on macOS version)

So I guess we'll again have to do this manual exclude here, after the fact, as another admin-request with the known build number?

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=279807&view=logs&jobId=58ac6aab-c4bc-5de2-2894-98e408cc8ec9 seems to say:

...
TEST END: /Users/runner/miniforge3/conda-bld/osx-64/rust-1.50.0-h7e1429e_0.tar.bz2

So I would assume a similar exclude now would be for:

osx-64/rust-1.50.0-h7e1429e_0.tar.bz2

Or do we raise this in advance?

isuruf · 2021-02-21T18:40:49Z

We can globally pin a dependency. For eg: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/master/recipe/conda_build_config.yaml#L419

mbargull · 2021-02-22T07:45:08Z

Before merging this, we need to pin rust to 1.48 on osx-64.

@isuruf, is this because of the minimum deployment target (#73)?
Just to get clarification: The rust package itself would itself work (i.e., marking 1.49 as broken was only temporary/workaround?) but we'd not use it downstream, i.e., pinning?

With the added build.sh and patch the builds complete much faster, but now conda-build is having troubles with the ~ 19k files.
Options to address this in this feedstock:

Wait until we can up the CI time on Drone.
Wait until conda-build handles many files considerably faster.
Skip linux-aarch64 for now..
Don't include the rust-docs component in the rust package on linux-aarch64.

IMO, it doesn't make sense to hold this up by waiting for 1. or 2., i.e., I'd go with 3. or 4.
I'm not too comfortable in having different contents for different platforms and would rather have a rust-docs exclusion "visible". Meaning, either we skip linux-aarch64 altogether for now, or we generally split out a new package rust-docs such that it is at least visible that you get rust->rust-docs on, e.g., linux-64, but only rust on linux-aarch64.

@conda-forge/rust, @isuruf: WDYT, which option to go for?

isuruf · 2021-02-22T07:59:47Z

is this because of the minimum deployment target (#73)?

yes

Just to get clarification: The rust package itself would itself work (i.e., marking 1.49 as broken was only temporary/workaround?) but we'd not use it downstream, i.e., pinning?

yes

WDYT, which option to go for?

option 5. cross compile

mbargull · 2021-02-22T08:02:29Z

option 5. cross compile

Ha, I'm a dummy! Of course! Thanks!

mbargull · 2021-02-22T08:12:48Z

@isuruf, we don't yet have a way to run (QEMU-based?) tests when cross-compiling, right?

isuruf · 2021-02-22T08:14:14Z

We do. Tests should work without any change.

mbargull · 2021-02-22T08:15:58Z

We do. Tests should work without any change.

Oh, nice! Even if test_on_native_only: true is set (because of the macOS ARM in this feedstock)?

isuruf · 2021-02-22T08:16:27Z

Nope. In that case, tests will not be run

mbargull · 2021-02-22T08:19:32Z

Nope. In that case, tests will not be run

Ah, okay. Personally, I think it's not too bad in this case (since all is precompiled anyway).

Thanks again!

Would it make sense to make test_on_native_only optionally a dict platform -> bool to distinguish?

…da-forge-pinning 2021.02.21.18.29.10

mbargull · 2021-02-22T12:31:26Z

recipe/build.sh

+# => replace path records beforehand:
+install_log="${DESTDIR}${PREFIX}/lib/rustlib/install.log"
+sed \
+  -e "s|${PREFIX}|/prefix|g" \
+  -e "s|${DESTDIR}|/destdir|g" \
+  -e "s|${PWD}|/source|g" \
+  -i.bak "${install_log}"
+rm "${install_log}.bak"


Alternative (if nobody wants/needs install.log):

Suggested change

# => replace path records beforehand:

install_log="${DESTDIR}${PREFIX}/lib/rustlib/install.log"

sed \

-e "s|${PREFIX}|/prefix|g" \

-e "s|${DESTDIR}|/destdir|g" \

-e "s|${PWD}|/source|g" \

-i.bak "${install_log}"

rm "${install_log}.bak"

# => remove install.log:

rm "${DESTDIR}${PREFIX}/lib/rustlib/install.log"

mbargull · 2021-02-22T13:30:28Z

Pending conda-forge/conda-forge-pinning-feedstock#1233 , this is ready for review.

I reverted to native linux-aarch64 builds because cross-platform build failed with

Traceback (most recent call last):
  File "/opt/conda/bin/conda-build", line 11, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.8/site-packages/conda_build/cli/main_build.py", line 481, in main
    execute(sys.argv[1:])
  File "/opt/conda/lib/python3.8/site-packages/conda_build/cli/main_build.py", line 470, in execute
    outputs = api.build(args.recipe, post=args.post, test_run_post=args.test_run_post,
  File "/opt/conda/lib/python3.8/site-packages/conda_build/api.py", line 186, in build
    return build_tree(
  File "/opt/conda/lib/python3.8/site-packages/conda_build/build.py", line 3068, in build_tree
    packages_from_this = build(metadata, stats,
  File "/opt/conda/lib/python3.8/site-packages/conda_build/build.py", line 2306, in build
    environ.create_env(m.config.host_prefix, host_actions, env='host',
  File "/opt/conda/lib/python3.8/site-packages/conda_build/environ.py", line 907, in create_env
    display_actions(actions, index)
  File "/opt/conda/lib/python3.8/site-packages/conda/exports.py", line 236, in display_actions
    actions['LINK'] = [index[d] for d in actions['LINK']]
  File "/opt/conda/lib/python3.8/site-packages/conda/exports.py", line 236, in <listcomp>
    actions['LINK'] = [index[d] for d in actions['LINK']]
KeyError: Dist(channel='conda-forge', dist_name='ld_impl_linux-aarch64-2.35.1-h02ad14f_2', name='ld_impl_linux-aarch64', fmt='.tar.bz2', version='2.35.1', build_string='h02ad14f_2', build_number=2, base_url=None, platform=None)

and I rather looked into why the build was slow rather than investigating into the conda-build+conda error above.

The CI job on Drone now barely finished under its 1 hour timeout; IDK why it's 4 times as slow as the linux-64 one on Azure, though (I expected a noticeable difference, but not that much).

isuruf · 2021-02-22T19:08:19Z

Would it make sense to make test_on_native_only optionally a dict platform -> bool to distinguish?

Yes. I think we can also have an option like,

test: <native-only/all/native-and-emulated>

and deprecate test_on_native_only option. What do you think?

…iltins.diff

mbargull · 2021-02-22T19:43:32Z

Yes. I think we can also have an option like,
test: <native-only/all/native-and-emulated>

What would all be in comparison to native-and-emulated?

I'm leaning more towards a host platform <-> test platform(s) mapping, but give me a bit to ponder about it (I'll open an issue on smithy to track this).

isuruf · 2021-02-22T19:46:46Z

What would all be in comparison to native-and-emulated?

all would test even in cross compiling. This is for when tests are like file existence tests. This is equivalent to test_on_native_only: false

mbargull · 2021-02-23T06:55:25Z

@isuruf, it makes sense to add https://conda-forge.org/docs/maintainer/knowledge_base.html?highlight=macosx_sdk_version#requiring-newer-macos-sdks

requirements:
  run:
    - __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }}  # [osx and x86_64]

and the accompanying keys in cbc.yaml for the rust output, right (or just __osx >=10.10 # [osx and x86_64], depending if one wants brevity or consistency)?

isuruf · 2021-02-23T19:17:10Z

recipe/meta.yaml

@@ -55,6 +62,7 @@ outputs:
      run:
        - {{ pin_subpackage("rust-std-" ~ rust_arch, exact=True) }}
        - gcc_impl_{{ target_platform }}  # [linux]
+        - __osx >={{ MACOSX_DEPLOYMENT_TARGET|default("10.9") }}  # [osx and x86_64]


This should be moved to run_exports

This doesn't make sense in run because the compiler itself can be run in 10.9, only the compiled binaries cannot be run which means we need run_exports.

Makes sense.
Are we comfortable in adding virtual packages to run generally? Reading https://github.com/conda/conda/blob/4.9.2/CHANGELOG.md#bug-fixes-2 it's still rather recent that bugs have been fixed regarding them.
Do we want run_exports: { strong: ... } or be rather conservative (in expecting that users may run older non-fixed conda versions) and use run_exports: { strong_constrains: ... }?

Do we want run_exports: { strong: ... } or be rather conservative (in expecting that users may run older non-fixed conda versions) and use run_exports: { strong_constrains: ... }?

Sure. I was gonna say no such thing exists, but it does. 😄 conda/conda-build#4125

regro-cf-autotick-bot added 2 commits February 11, 2021 16:23

updated v1.50.0

ea6c6e3

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.8.6, and con…

2716cb4

…da-forge-pinning 2021.02.11.03.11.06

regro-cf-autotick-bot requested review from abhi18av, dlaehnemann, isuruf, johanneskoester and pkgw as code owners February 11, 2021 16:24

conda-forge-linter closed this Feb 17, 2021

conda-forge-linter reopened this Feb 17, 2021

Avoid twofold build; remove .old backups from rust

66513eb

mbargull reviewed Feb 19, 2021

View reviewed changes

recipe/install-rust.sh Show resolved Hide resolved

mbargull added 2 commits February 19, 2021 13:42

Add 0001-conda-forgegh-106-install.sh-Perfomance-Use-more-shell-built…

2fd5b38

…ins.patch

Adjust patch for filename/mode

1ac4c7f

mbargull added 5 commits February 22, 2021 09:41

Cross build for linux-aarch64

f6175bb

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.8.6, and con…

cee4d72

…da-forge-pinning 2021.02.21.18.29.10

Replace prefix paths in install.log

6386291

linux-aarch64: Use native build again

4d7dbec

MNT: Re-rendered with conda-build 3.21.4, conda-smithy 3.8.6, and con…

016ba74

…da-forge-pinning 2021.02.21.18.29.10

mbargull reviewed Feb 22, 2021

View reviewed changes

mbargull force-pushed the 1.50.0_hcfb706 branch 3 times, most recently from aed30d0 to 219aa29 Compare February 22, 2021 19:21

Update 0001-conda-forgegh-106-install.sh-Perfomance-Use-more-shell-bu…

b1dd508

…iltins.diff

mbargull force-pushed the 1.50.0_hcfb706 branch from 219aa29 to b1dd508 Compare February 22, 2021 19:27

mbargull mentioned this pull request Feb 22, 2021

Refine test_on_native_only option in case of multiple cross built platforms conda-forge/conda-smithy#1455

Closed

Add __osx>=10.10 requirement for osx-64

c9cb0f9

mbargull mentioned this pull request Feb 23, 2021

Fix small typo in activate.sh, use rust=1.51 (1.46 for osx-64) conda-forge/rust-activation-feedstock#8

Merged

1 task

isuruf reviewed Feb 23, 2021

View reviewed changes

Move __osx>=10.10 to run_exports/strong_constrains

84dbfd2

isuruf merged commit 0e25bdf into conda-forge:master Feb 26, 2021

regro-cf-autotick-bot deleted the 1.50.0_hcfb706 branch February 26, 2021 20:18

pkgw mentioned this pull request Apr 10, 2021

Update rust nightly to 1.53.0 2021-03-24 #79

Merged

5 tasks

isuruf mentioned this pull request Nov 27, 2023

Check build stability conda-forge/ray-packages-feedstock#128

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rust v1.50.0 #75

rust v1.50.0 #75

regro-cf-autotick-bot commented Feb 11, 2021

conda-forge-linter commented Feb 11, 2021

pkgw commented Feb 11, 2021

pkgw commented Feb 17, 2021

pkgw commented Feb 18, 2021

ocefpaf commented Feb 18, 2021

mbargull commented Feb 19, 2021

mbargull commented Feb 19, 2021

pkgw commented Feb 19, 2021

isuruf commented Feb 19, 2021 •

edited

Loading

stain commented Feb 21, 2021 •

edited

Loading

isuruf commented Feb 21, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

mbargull Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 23, 2021

isuruf Feb 23, 2021

isuruf Feb 23, 2021

mbargull Feb 23, 2021

isuruf Feb 23, 2021

rust v1.50.0 #75

rust v1.50.0 #75

Conversation

regro-cf-autotick-bot commented Feb 11, 2021

Dependency Analysis

Packages found by inspection but not in the meta.yaml:

conda-forge-linter commented Feb 11, 2021

pkgw commented Feb 11, 2021

pkgw commented Feb 17, 2021

pkgw commented Feb 18, 2021

ocefpaf commented Feb 18, 2021

mbargull commented Feb 19, 2021

mbargull commented Feb 19, 2021

pkgw commented Feb 19, 2021

isuruf commented Feb 19, 2021 • edited Loading

stain commented Feb 21, 2021 • edited Loading

isuruf commented Feb 21, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

mbargull Feb 22, 2021

Choose a reason for hiding this comment

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 22, 2021

isuruf commented Feb 22, 2021

mbargull commented Feb 23, 2021

isuruf Feb 23, 2021

Choose a reason for hiding this comment

isuruf Feb 23, 2021

Choose a reason for hiding this comment

mbargull Feb 23, 2021

Choose a reason for hiding this comment

isuruf Feb 23, 2021

Choose a reason for hiding this comment

isuruf commented Feb 19, 2021 •

edited

Loading

stain commented Feb 21, 2021 •

edited

Loading