Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add homeassistant #16274

Merged
merged 30 commits into from
Sep 30, 2021
Merged

Add homeassistant #16274

merged 30 commits into from
Sep 30, 2021

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Sep 25, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/homeassistant) and found some lint.

Here's what I've got...

For recipes/homeassistant:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@jan-janssen
Copy link
Member Author

Waiting for #16272 and conda-forge/astral-feedstock#9

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/awesomeversion, recipes/homeassistant, recipes/voluptuous-serialize) and found some lint.

Here's what I've got...

For recipes/awesomeversion:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/homeassistant:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

For recipes/voluptuous-serialize:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/awesomeversion, recipes/homeassistant, recipes/voluptuous-serialize) and found some lint.

Here's what I've got...

For recipes/homeassistant:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@jan-janssen
Copy link
Member Author

Include license in pip package upstream home-assistant-libs/voluptuous-serialize#32

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/awesomeversion, recipes/homeassistant, recipes/voluptuous-serialize) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/awesomeversion, recipes/homeassistant, recipes/voluptuous-serialize) and found some lint.

Here's what I've got...

For recipes/homeassistant:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/awesomeversion, recipes/homeassistant, recipes/voluptuous-serialize) and found it was in an excellent condition.

@jan-janssen
Copy link
Member Author

The majority of the changes in the patch are already included in the latest development version. I just created a pull request to support the latest pip version upstream home-assistant/core#56674

@jan-janssen
Copy link
Member Author

WARNING: failed to get_linkages, codefile_type('C:\Miniconda\conda-bld\homeassistant_1632635709959\_h_env\Scripts\hass.exe')=EXEfile
   INFO: sysroot: 'C:/Windows/' files: '['winhlp32.exe', 'win.ini', 'twain_32/wiatwain.ds', 'twain_32.dll']'
WARNING (homeassistant): interpreted library (Python) package conda-forge::pip-21.2.4-pyhd8ed1ab_0 in requirements/run but it is not used (i.e. it is overdepending or perhaps statically linked? If that is what you want then add it to `build/ignore_run_exports`)
   INFO (homeassistant): Interpreted package 'homeassistant' is interpreted by 'python'
[noarch_python] Noarch package contains binary script: hass.exe

@jan-janssen
Copy link
Member Author

@conda-forge/staged-recipes, ready for review

1 similar comment
@jan-janssen
Copy link
Member Author

@conda-forge/staged-recipes, ready for review

number: 0
script: {{ PYTHON }} -m pip install . -vv
skip: true # [py<38]
skip: true # [py>38]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not # [not py38] instead?

@ocefpaf ocefpaf merged commit 27cbd68 into conda-forge:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants