Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added dataconf as a package. #16841

Merged
merged 3 commits into from
Nov 10, 2021
Merged

Added dataconf as a package. #16841

merged 3 commits into from
Nov 10, 2021

Conversation

thewchan
Copy link
Contributor

@thewchan thewchan commented Nov 7, 2021

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/dataconf) and found it was in an excellent condition.

@thewchan
Copy link
Contributor Author

thewchan commented Nov 7, 2021

@conda-forge/staged-recipes ready for review!

dopplershift
dopplershift reviewed Nov 9, 2021
View reviewed changes
recipes/dataconf/meta.yaml Outdated
Comment on lines 24 to 27
- python >=3.6,<4.0
run:
- pyhocon >=0.3.54,<0.4.0
- python >=3.6,<4.0
Copy link
Member

@dopplershift dopplershift Nov 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream says python >=3.8?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change this, I must have missed checking this and just used default from GS

dopplershift
dopplershift reviewed Nov 9, 2021
View reviewed changes
recipes/dataconf/meta.yaml Outdated

extra:
recipe-maintainers:
- MattChanTK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not thewchan?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, not sure why that's the default from grayskull... sometimes I forget to change it

@thewchan
Copy link
Contributor Author

thewchan commented Nov 9, 2021

@dopplershift addressed your comments

@dopplershift dopplershift merged commit c6ed757 into conda-forge:main Nov 10, 2021
@thewchan thewchan deleted the dataconf branch July 30, 2022 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thewchan @conda-forge-linter @dopplershift