Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nvidia-ml-py. #20183

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Add nvidia-ml-py. #20183

merged 1 commit into from
Sep 29, 2022

Conversation

XuehaiPan
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-ml-py) and found some lint.

Here's what I've got...

For recipes/nvidia-ml-py:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@XuehaiPan XuehaiPan mentioned this pull request Aug 25, 2022
10 tasks
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-ml-py, recipes/nvitop) and found some lint.

Here's what I've got...

For recipes/nvidia-ml-py:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/nvitop:

  • license_file entry is missing, but is required.
  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-ml-py, recipes/nvitop) and found some lint.

Here's what I've got...

For recipes/nvidia-ml-py:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

For recipes/nvitop:

  • license_file entry is missing, but is required.
  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@XuehaiPan XuehaiPan force-pushed the nvidia-ml-py branch 2 times, most recently from 134e39e to eac3ae2 Compare August 25, 2022 12:27
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-ml-py) and found some lint.

Here's what I've got...

For recipes/nvidia-ml-py:

  • noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-ml-py) and found some lint.

Here's what I've got...

For recipes/nvidia-ml-py:

  • license_file entry is missing, but is required.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/nvidia-ml-py) and found it was in an excellent condition.

@XuehaiPan XuehaiPan force-pushed the nvidia-ml-py branch 3 times, most recently from 0fb3bb0 to cb5f812 Compare August 25, 2022 12:59
Comment on lines +23 to +25
run_constrained:
- nvidia-ml ==9999999999
- pynvml ==9999999999
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both package nvidia-ml and pynvml modify module pynvml.py in site-packges. They are in conflict with nvidia-ml-py (the official NVML Python Bindings maintained by NVIDIA).

@XuehaiPan
Copy link
Member Author

@conda-forge/help-python, ready for review!

@BastianZim BastianZim merged commit f09b9a5 into conda-forge:main Sep 29, 2022
@XuehaiPan XuehaiPan deleted the nvidia-ml-py branch October 6, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants