-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for lie-group-controllers #20429
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/lie-group-controllers:
Documentation on acceptable licenses can be found here. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-c-cpp The recipe is ready for review. @h-vetinari This is a C++ header-only library, do you think the output should be called |
I don't have a very strong opinion on this case (I'm mainly against adding more |
Ack, I change the name to |
build: | ||
number: 0 | ||
run_exports: | ||
- {{ pin_subpackage(name, max_pin='x.x.x') }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need a run exports if this is header-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I made an error and assumed the library was not header only, I will fix this.
@conda-forge/help-c-cpp @saraedum Thanks for the comments, I tried to address all your comments. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).