Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Recipe for AutoKeras #21049

Merged
merged 10 commits into from
Nov 9, 2022
Merged

Add Recipe for AutoKeras #21049

merged 10 commits into from
Nov 9, 2022

Conversation

Anselmoo
Copy link
Member

@Anselmoo Anselmoo commented Nov 7, 2022 •
edited
Loading

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras, recipes/examples) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes/examples:

  • There are too few lines. There should be one empty line at the end of the file.
  • Feedstock with the same name exists in conda-forge.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

For recipes/examples:

  • A conda package with same name (simplejson) already exists.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found it was in an excellent condition.

@Anselmoo
Add Recipe for AutoKeras
daae8b9 
See also: https://github.com/keras-team/autokeras

Skipped windows due to  missing compatibility, see also: conda-forge/tensorflow-feedstock#124
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • noarch packages can't have skips with selectors. If the selectors are necessary, please remove noarch: python.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • Non noarch packages should have python requirement without any version constraints.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found it was in an excellent condition.

@Anselmoo
Copy link
Member Author

Anselmoo commented Nov 7, 2022

@conda-forge-admin, please rerender

@Anselmoo
Copy link
Member Author

Anselmoo commented Nov 7, 2022

@conda-forge/help-python

dopplershift
dopplershift requested changes Nov 8, 2022
View reviewed changes
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes, the biggest of which is to make this noarch (which drastically cuts down the number of builds). We can ignore any CI build failures on Windows due to missing dependencies (since by default noarch packages are only built on Linux).

recipes/example/meta.yaml Outdated Show resolved Hide resolved
recipes/autokeras/meta.yaml Outdated Show resolved Hide resolved
recipes/autokeras/LICENSE Outdated Show resolved Hide resolved
recipes/autokeras/meta.yaml Outdated Show resolved Hide resolved
Anselmoo
Anselmoo commented Nov 9, 2022
View reviewed changes
Copy link
Member Author

@Anselmoo Anselmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meta.yaml is reformat

recipes/example/meta.yaml Outdated Show resolved Hide resolved
@Anselmoo Anselmoo requested a review from dopplershift November 9, 2022 06:11
Anselmoo and others added 2 commits November 9, 2022 13:52
@Anselmoo @dopplershift
Update recipes/autokeras/meta.yaml
6a55d2d 
Not possible with current feedstock of tensor flow

Co-authored-by: Ryan May <[email protected]>
@Anselmoo @dopplershift
Update recipes/autokeras/meta.yaml
1b81f77 
Co-authored-by: Ryan May <[email protected]>
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@Anselmoo
Revert "Update recipes/autokeras/meta.yaml"
31d3c85 
This reverts commit 1b81f77.

Revert "Update recipes/autokeras/meta.yaml"

This reverts commit 6a55d2d.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found it was in an excellent condition.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found some lint.

Here's what I've got...

For recipes/autokeras:

  • noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/autokeras) and found it was in an excellent condition.

@dopplershift
Copy link
Member

Ignoring noarch Windows build failure due to missing dependency.

@dopplershift dopplershift merged commit d94626e into conda-forge:main Nov 9, 2022
@Anselmoo Anselmoo mentioned this pull request Oct 23, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

Assignees
No one assigned
Labels
python review-requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Anselmoo @conda-forge-linter @dopplershift