Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conda-mirror #2526

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Add conda-mirror #2526

merged 1 commit into from
Mar 4, 2017

Conversation

jakirkham
Copy link
Member

Adds a package for conda-mirror.

cc @ericdill @mariusvniekerk

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/conda-mirror) and found it was in an excellent condition.

jakirkham
jakirkham commented Feb 28, 2017
View reviewed changes
recipes/conda-mirror/meta.yaml Outdated
- conda-mirror --help

about:
home: https://github.com/ericdill/conda-mirror
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is intentional or if it should change. Please let me know either way. Opened issue ( adtech-labs/conda-mirror#35 ) about this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is definitely the wrong url. Thanks for the fix here. Merging the PR that fixes this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, have updated here too.

jakirkham
jakirkham commented Feb 28, 2017
View reviewed changes
recipes/conda-mirror/meta.yaml Outdated
#
# https://github.com/maxpoint/conda-mirror/issues/36
#
# license_file: LICENSE
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license file is not currently packaged in the sdist. Have raised issue ( adtech-labs/conda-mirror#36 ) to discuss addressing this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be fixed in the next release.

jakirkham
jakirkham commented Feb 28, 2017
View reviewed changes
recipes/conda-mirror/meta.yaml

extra:
recipe-maintainers:
- ericdill
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have added you as the maintainer, @ericdill. Please let me know if that is ok. If there are others that should be added, please let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks. Add @parente too please

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jakirkham jakirkham mentioned this pull request Feb 28, 2017
Closed
jakirkham
jakirkham commented Mar 1, 2017
View reviewed changes
recipes/conda-mirror/meta.yaml
extra:
recipe-maintainers:
- ericdill
- parente
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double checking that this is ok, @parente.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Fine by me.

@jakirkham
Copy link
Member Author

Thoughts @conda-forge/staged-recipes?

@jakirkham jakirkham merged commit 2167e6f into conda-forge:master Mar 4, 2017
@jakirkham jakirkham deleted the add_conda-mirror branch March 4, 2017 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdill ericdill ericdill left review comments

@parente parente parente left review comments

Assignees
No one assigned
Labels
Package request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jakirkham @conda-forge-linter @parente @ericdill