-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for multiformats-config package #28790
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/multiformats-config/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12756323035. Examine the logs at this URL for more detail. |
I'd help out maintaining. |
@conda-forge/help-python ready for the review! |
@conda-forge-admin, please restart ci |
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
@conda-forge-admin, please ping team |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/staged-recipes and so here I am doing that. |
To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks! |
imports: | ||
- multiformats_config | ||
commands: | ||
- pip install multiformats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not allowed in conda-forge. You must package that too.
- pip install multiformats |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is, that the packages have a circular dependency. We already tried to solve this in an earlier PR #28404 which failed for other technical issues.
Is there an official way how to handle such an issue in conda-forge?
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).