Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for multiformats-config package #28790

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lkluft
Copy link
Contributor

@lkluft lkluft commented Jan 8, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 8, 2025

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/multiformats-config/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: d70-t. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 8, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/multiformats-config/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/multiformats-config/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12756323035. Examine the logs at this URL for more detail.

@d70-t
Copy link

d70-t commented Jan 8, 2025

I'd help out maintaining.

@lkluft
Copy link
Contributor Author

lkluft commented Jan 13, 2025

@conda-forge/help-python ready for the review!

@d70-t
Copy link

d70-t commented Jan 13, 2025

@conda-forge-admin, please restart ci

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@lkluft
Copy link
Contributor Author

lkluft commented Jan 27, 2025

@conda-forge-admin, please ping team

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

imports:
- multiformats_config
commands:
- pip install multiformats
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not allowed in conda-forge. You must package that too.

Suggested change
- pip install multiformats

Copy link
Contributor Author

@lkluft lkluft Jan 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is, that the packages have a circular dependency. We already tried to solve this in an earlier PR #28404 which failed for other technical issues.

Is there an official way how to handle such an issue in conda-forge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants