-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add winloop package #28817
base: main
Are you sure you want to change the base?
Add winloop package #28817
Conversation
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/winloop/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12731537121. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
The winloop repo which I don't own or maintain unfortunately vendors in libuv. I think I could update the recipe to remove the vendored libuv and add libuv as a dependency for this recipe, but unfortunately the author @Vizonex has vendored a commit that doesn't appear to correspond to a release tag of libuv - I'll try reaching out to see if that can be changed to correspond to a specific release of libuv. I'm happy to wait to see if we can setup this dependency better if you'd like. |
The original repo is dual licensed with references to the vendored libuv licences - I've not sure if I've referenced those properly in this PR. |
@conda-forge/help-python-c, ready for review! |
On Sun, Jan 12, 2025 at 3:22 AM Owen Lamont ***@***.***> wrote:
@conda-forge/help-python-c
<https://github.com/orgs/conda-forge/teams/help-python-c>, ready for
review!
—
Reply to this email directly, view it on GitHub
<#28817 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3K7GGUTXZFWXLYQOCYDGW32KIX5VAVCNFSM6AAAAABVAYBECWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBVGY2TMMJZGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
I’ll have to look into it at some point sorry for the inconveniences.
|
I've naively tried to make winloop depend on the libuv package, but I think the way winloop is designed it wants to build libuv from source as part of itself. I'm not sure I have the time/skills to resolve this. Will see if any options arise soon that are simpler than what I'm currently aware of otherwise I think I'll abandon this PR and leave it to someone with better Python / C integration skills. |
I've switched back to the vendored libuv for now if we're okay with this as an interim solution. I checked the uvloop conda-forge recipe which is the equivalent package for Posix OSes. They don't vendor libuv and do use the conda-forge dependency but they have some build configuration (which winloop doesn't yet have) to switch from statically linking to dynamically linking with libuv. I'll see if the winloop maintainers are open to doing something similar. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).