Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pkld #28818

Merged
merged 8 commits into from
Jan 20, 2025
Merged

Add pkld #28818

merged 8 commits into from
Jan 20, 2025

Conversation

paulcbogdan
Copy link
Contributor

@paulcbogdan paulcbogdan commented Jan 12, 2025

Made meta.yml in recipes

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Made meta.yml in recipes
Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 12, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pkld/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pkld/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12854557777. Examine the logs at this URL for more detail.

@shobrook
Copy link

I'm the other maintainer of this package and I'm confirming that I'm willing to be listed.

Hopefully this works, not entirely clear what the issue is
@paulcbogdan paulcbogdan marked this pull request as ready for review January 19, 2025 10:33
recipes/pkld/meta.yaml Outdated Show resolved Hide resolved
host:
- python >=3.7
- pip
- numpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can delete numpy and filelock from the host section.

recipes/pkld/meta.yaml Outdated Show resolved Hide resolved
recipes/pkld/meta.yaml Show resolved Hide resolved
recipes/pkld/meta.yaml Outdated Show resolved Hide resolved
paulcbogdan and others added 4 commits January 19, 2025 20:54
Co-authored-by: Joshua Adelman <[email protected]>
Co-authored-by: Joshua Adelman <[email protected]>
Co-authored-by: Joshua Adelman <[email protected]>
Co-authored-by: Joshua Adelman <[email protected]>
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pkld/meta.yaml) and found it was in an excellent condition.

@paulcbogdan
Copy link
Contributor Author

Thank you synapticarbors, sorry about that. I think the first time I launched a package on conda-forge, the ,yaml worked exactly as output by greyskull but seemingly not this time.

@synapticarbors
Copy link
Member

I'm not sure if grayskull handles the new noarch requirements (https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python). Also if you could just delete numpy and filelock from host, assuming the CI passes, I'll be happy to merge. Also as a note, it doesn't look like numpy is a strict requirement. It gets a deferred import within the library from within a function, but isn't listed in the package metadata. I'm not sure how you want to handle this, but technically, I think you can delete the numpy requirement from run as well.

Copy link
Contributor Author

@paulcbogdan paulcbogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@paulcbogdan
Copy link
Contributor Author

I appreciate your patience. Hopefully this works

@synapticarbors synapticarbors merged commit a57aa1d into conda-forge:main Jan 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants